AC-15461: Migration New Relic from REST v2 to NerdGraph (GraphQL)

sandesh-as · sandesh-as · commit 7646ac639e02 · 2025-09-15T09:33:40.000+05:30
diff --git a/app/code/Magento/NewRelicReporting/Console/Command/DeployMarker.php b/app/code/Magento/NewRelicReporting/Console/Command/DeployMarker.php
@@ -44,7 +44,7 @@ public function __construct(
         DeploymentsFactory $deploymentsFactory,
         ServiceShellUser $serviceShellUser,
         Config $config,
-        string $name = null
+        ?string $name = null
     ) {
         $this->deploymentsFactory = $deploymentsFactory;
         $this->serviceShellUser = $serviceShellUser;
diff --git a/app/code/Magento/NewRelicReporting/Test/Unit/Model/Observer/ReportSystemCacheFlushToNewRelicTest.php b/app/code/Magento/NewRelicReporting/Test/Unit/Model/Observer/ReportSystemCacheFlushToNewRelicTest.php
@@ -127,7 +127,7 @@ public function testReportSystemCacheFlushToNewRelic()
             ->willReturn($this->deploymentsModel);
         $this->deploymentsModel->expects($this->once())
             ->method('setDeployment')
-            ->willReturnSelf();
+            ->willReturn(true);
 
         $this->model->execute($eventObserver);
     }

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ public function testReportSystemCacheFlushToNewRelic()`
`127`	`127`	`->willReturn($this->deploymentsModel);`
`128`	`128`	`$this->deploymentsModel->expects($this->once())`
`129`	`129`	`->method('setDeployment')`
`130`		`- ->willReturnSelf();`
	`130`	`+ ->willReturn(true);`
`131`	`131`
`132`	`132`	`$this->model->execute($eventObserver);`
`133`	`133`	`}`