ACP2E-1155: Refunding Issue Rest API

Author: Anna Bukatar

app/code/Magento/Sales/Model/Order/Validation/CanRefundTrait.php

@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Sales\Model\Order\Validation;
 
 use Magento\Framework\App\Config\ScopeConfigInterface;

app/code/Magento/Sales/Test/Unit/Model/Order/Creditmemo/Validation/QuantityValidatorTest.php

@@ -8,13 +8,16 @@
 namespace Magento\Sales\Test\Unit\Model\Order\Creditmemo\Validation;
 
 use Magento\Framework\Pricing\PriceCurrencyInterface;
+use Magento\Framework\App\Config\ScopeConfigInterface;
+use Magento\Sales\Model\Order\Creditmemo;
 use Magento\Sales\Api\Data\CreditmemoInterface;
 use Magento\Sales\Api\Data\CreditmemoItemInterface;
 use Magento\Sales\Api\Data\OrderInterface;
 use Magento\Sales\Api\InvoiceRepositoryInterface;
 use Magento\Sales\Api\OrderRepositoryInterface;
 use Magento\Sales\Model\Order\Creditmemo\Validation\QuantityValidator;
 use Magento\Sales\Model\Order\Item;
+use Magento\Store\Api\Data\StoreConfigInterface;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
@@ -154,6 +157,30 @@ public function testValidateWithWrongItemId()
         );
     }
 
+    private function getCreditMemoMockParams()
+    {
+        return [
+            $this->createMock(\Magento\Framework\Model\Context::class),
+            $this->createMock(\Magento\Framework\Registry::class),
+            $this->createMock(\Magento\Framework\Api\ExtensionAttributesFactory::class),
+            $this->createMock(\Magento\Framework\Api\AttributeValueFactory::class),
+            $this->createMock(\Magento\Sales\Model\Order\Creditmemo\Config::class),
+            $this->createMock(\Magento\Sales\Model\OrderFactory::class),
+            $this->createMock(\Magento\Sales\Model\ResourceModel\Order\Creditmemo\Item\CollectionFactory::class),
+            $this->createMock(\Magento\Framework\Math\CalculatorFactory::class),
+            $this->createMock(\Magento\Store\Model\StoreManagerInterface::class),
+            $this->createMock( \Magento\Sales\Model\Order\Creditmemo\CommentFactory::class),
+            $this->createMock(\Magento\Sales\Model\ResourceModel\Order\Creditmemo\Comment\CollectionFactory::class),
+            $this->createMock(\Magento\Framework\Pricing\PriceCurrencyInterface::class),
+            $this->createMock(\Magento\Framework\Model\ResourceModel\AbstractResource::class),
+            $this->createMock(\Magento\Framework\Data\Collection\AbstractDb::class),
+            [],
+            $this->createMock(\Magento\Sales\Model\Order\InvoiceFactory::class),
+            $this->createMock(ScopeConfigInterface::class),
+            $this->createMock(\Magento\Sales\Api\OrderRepositoryInterface::class)
+        ];
+    }
+
     /**
      * @param int $orderId
      * @param int $orderItemId
@@ -163,6 +190,7 @@ public function testValidateWithWrongItemId()
      * @param int $total
      * @param array $expected
      * @param bool $isQtyDecimalAllowed
+     * @param bool $isAllowZeroGrandTotal
      * @dataProvider dataProviderForValidateQty
      */
     public function testValidate(
@@ -174,16 +202,23 @@ public function testValidate(
         $total,
         array $expected,
         bool $isQtyDecimalAllowed,
-        bool $isValidGrandTotal
+        bool $isAllowZeroGrandTotal
     ) {
-        $creditmemoMock = $this->getMockBuilder(CreditmemoInterface::class)
-            ->disableOriginalConstructor()
-            ->addMethods(['isValidGrandTotal'])
+        $scopeConfig = $this->getMockForAbstractClass(ScopeConfigInterface::class);
+        $scopeConfig->expects($this->any())->method('getValue')->willReturn($isAllowZeroGrandTotal);
+        $creditMemoConstructorParams = $this->getCreditMemoMockParams();
+        $creditMemoConstructorParams[16] = $scopeConfig;
+
+        $creditmemoMock = $this->getMockBuilder(Creditmemo::class)
+            ->setConstructorArgs($creditMemoConstructorParams)
+            ->onlyMethods(['getOrderId', 'getItems', 'getGrandTotal', '_construct'])
             ->getMockForAbstractClass();
+
         $creditmemoMock->expects($this->exactly(2))->method('getOrderId')
             ->willReturn($orderId);
-        $creditmemoMock->expects($this->once())->method('isValidGrandTotal')
-            ->willReturn($isValidGrandTotal);
+        $creditmemoMock->expects($this->once())->method('getGrandTotal')
+            ->willReturn($total);
+
         $creditmemoItemMock = $this->getMockBuilder(
             CreditmemoItemInterface::class
         )->disableOriginalConstructor()
@@ -244,7 +279,7 @@ public function dataProviderForValidateQty()
                 'total' => 15,
                 'expected' => [],
                 'isQtyDecimalAllowed' => false,
-                'isValidGrandTotal' => true
+                'isAllowZeroGrandTotal' => true
             ],
             [
                 'orderId' => 1,
@@ -255,7 +290,7 @@ public function dataProviderForValidateQty()
                 'total' => 15,
                 'expected' => [],
                 'isQtyDecimalAllowed' => false,
-                'isValidGrandTotal' => true
+                'isAllowZeroGrandTotal' => true
             ],
             [
                 'orderId' => 1,
@@ -271,7 +306,7 @@ public function dataProviderForValidateQty()
                     )
                 ],
                 'isQtyDecimalAllowed' => false,
-                'isValidGrandTotal' => true
+                'isAllowZeroGrandTotal' => true
             ],
             [
                 'orderId' => 1,
@@ -300,7 +335,7 @@ public function dataProviderForValidateQty()
                 'total' => 0,
                 'expected' => [],
                 'isQtyDecimalAllowed' => false,
-                'isValidGrandTotal' => true
+                'isAllowZeroGrandTotal' => true
             ]
         ];
     }