B2B-2139: [AWS S3] Flaky Tests: StorefrontCustomerCheckoutWithNewCustomerRegistrationAndDisableGuestCheckoutTest & StorefrontAutoGeneratedCouponCodeTest & AdminContentThemesEditTest

 - Fixing flaky tests

Author: dhaecker

app/code/Magento/Checkout/Test/Mftf/ActionGroup/StorefrontSignOutActionGroup.xml

@@ -16,6 +16,6 @@
         <click selector="{{StoreFrontSignOutSection.customerAccount}}" stepKey="clickCustomerButton"/>
         <click selector="{{StoreFrontSignOutSection.signOut}}" stepKey="clickToSignOut"/>
         <waitForPageLoad stepKey="waitForPageLoad"/>
-        <see userInput="You are signed out" stepKey="signOut"/>
+        <waitForText userInput="You are signed out" stepKey="signOut"/>
     </actionGroup>
 </actionGroups>

app/code/Magento/Checkout/Test/Mftf/Test/StorefrontCustomerCheckoutWithNewCustomerRegistrationAndDisableGuestCheckoutTest.xml

@@ -62,8 +62,8 @@
         <actionGroup ref="StorefrontFillCustomerAccountCreationFormActionGroup" stepKey="createNewCustomerAccount">
             <argument name="customer" value="Simple_US_Customer" />
         </actionGroup>
-        <click stepKey="clickCreateAccountButton" selector="{{StorefrontCustomerCreateFormSection.createAccountButton}}"/>
-        <waitForPageLoad stepKey="waitForCreateAccountButtonToLoad"/>
+        <actionGroup ref="StorefrontClickCreateAnAccountCustomerAccountCreationFormActionGroup" stepKey="clickCreateAccountButton"/>
+        <comment userInput="BIC workaround" stepKey="waitForCreateAccountButtonToLoad"/>
 
         <!--Assert customer information-->
         <see stepKey="seeThankYouMessage" userInput="Thank you for registering with Main Website Store."/>

app/code/Magento/Customer/Test/Mftf/ActionGroup/StorefrontSignOutActionGroup.xml

@@ -16,6 +16,6 @@
         <click selector="{{StoreFrontSignOutSection.customerAccount}}" stepKey="clickCustomerButton"/>
         <click selector="{{StoreFrontSignOutSection.signOut}}" stepKey="clickToSignOut"/>
         <waitForPageLoad stepKey="waitForPageLoad"/>
-        <see userInput="You are signed out" stepKey="signOut"/>
+        <waitForText userInput="You are signed out" stepKey="signOut"/>
     </actionGroup>
 </actionGroups>

app/code/Magento/Theme/Test/Mftf/ActionGroup/AdminClickViewThemeByThemeActionGroup.xml

@@ -0,0 +1,20 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AdminClickViewThemeBySpecifiedThemeActionGroup">
+        <annotations>
+            <description>Click the 'View' action of the specified theme on the themes grid.</description>
+        </annotations>
+        <arguments>
+            <argument name="theme" defaultValue="{{MagentoBlankTheme.themeTitle}}" type="string"/>
+        </arguments>
+        <click selector="{{AdminThemeSection.viewActionByTheme(theme)}}" stepKey="clickViewTheme"/>
+    </actionGroup>
+</actionGroups>

app/code/Magento/Theme/Test/Mftf/Section/AdminThemeSection.xml

@@ -19,5 +19,6 @@
         <element name="gridCellUpdated" type="text" selector="//tbody//tr//div[contains(text(), '{{gridCellText}}')]" parameterized="true"/>
         <element name="columnHeader" type="text" selector="//thead/tr/th[contains(@class, 'data-grid-th')]/span[text() = '{{label}}']" parameterized="true" timeout="30"/>
         <element name="viewAction" type="button" selector="tr.data-row > td.data-grid-actions-cell > a.action-menu-item"/>
+        <element name="viewActionByTheme" type="button" selector="//tr[@class='data-row']//td//div[@class='data-grid-cell-content' and text()='{{theme}}']//ancestor::tr//td[@class='data-grid-actions-cell']/a[@class='action-menu-item']" parameterized="true"/>
     </section>
 </sections>

app/code/Magento/Theme/Test/Mftf/Test/AdminContentThemesEditTest.xml

@@ -32,7 +32,9 @@
             <argument name="title" value="{{AdminMenuContentDesignThemes.pageTitle}}"/>
         </actionGroup>
 
-        <actionGroup ref="AdminClickViewThemeActionGroup" stepKey="editTheme"/>
+        <actionGroup ref="AdminClickViewThemeBySpecifiedThemeActionGroup" stepKey="editTheme">
+            <argument name="title" value="{{MagentoBlankTheme.themeTitle}}"/>
+        </actionGroup>
 
         <actionGroup ref="AdminAssertPageTitleActionGroup" stepKey="seeEditPageTitle">
             <argument name="title" value="{{MagentoBlankTheme.pageTitle}}"/>