MC-41807: Partial Catalog Product Price Indexing not removing old price date and is extremely slow if store has many products (above 200k)

Author: dhorytskyi

app/code/Magento/CatalogRule/Cron/DailyCatalogUpdate.php

@@ -6,8 +6,8 @@
 
 namespace Magento\CatalogRule\Cron;
 
-use Magento\CatalogRule\Model\Indexer\PartialIndex;
 use Magento\CatalogRule\Model\Indexer\Rule\RuleProductProcessor;
+use Magento\CatalogRule\Model\ResourceModel\Rule\CollectionFactory as RuleCollectionFactory;
 
 /**
  * Daily update catalog price rule by cron
@@ -20,24 +20,25 @@ class DailyCatalogUpdate
     protected $ruleProductProcessor;
 
     /**
-     * @var PartialIndex
+     * @var RuleCollectionFactory
      */
-    private $partialIndex;
+    private $ruleCollectionFactory;
 
     /**
      * @param RuleProductProcessor $ruleProductProcessor
-     * @param PartialIndex $partialIndex
+     * @param RuleCollectionFactory $ruleCollectionFactory
      */
     public function __construct(
         RuleProductProcessor $ruleProductProcessor,
-        PartialIndex $partialIndex
+        RuleCollectionFactory $ruleCollectionFactory
     ) {
         $this->ruleProductProcessor = $ruleProductProcessor;
-        $this->partialIndex = $partialIndex;
+        $this->ruleCollectionFactory = $ruleCollectionFactory;
     }
 
     /**
      * Daily update catalog price rule by cron
+     *
      * Update include interval 3 days - current day - 1 days before + 1 days after
      * This method is called from cron process, cron is working in UTC time and
      * we should generate data for interval -1 day ... +1 day
@@ -46,8 +47,10 @@ public function __construct(
      */
     public function execute()
     {
-        $this->ruleProductProcessor->isIndexerScheduled()
-            ? $this->partialIndex->partialUpdateCatalogRuleProductPrice()
-            : $this->ruleProductProcessor->markIndexerAsInvalid();
+        $ruleCollection = $this->ruleCollectionFactory->create();
+        $ruleCollection->addIsActiveFilter();
+        if ($ruleCollection->getSize()) {
+            $this->ruleProductProcessor->markIndexerAsInvalid();
+        }
     }
 }

app/code/Magento/CatalogRule/Model/Indexer/PartialIndex.php

@@ -27,7 +27,6 @@
     <view id="catalog_product_price" class="Magento\Catalog\Model\Indexer\Product\Price" group="indexer">
         <subscriptions>
             <table name="catalogrule_product_price" entity_column="product_id" />
-            <table name="catalogrule_product_price_replica" entity_column="product_id" />
         </subscriptions>
     </view>
 </config>