AC-2855::Removed overriden methods and now interceptor will not override core inbuilt methods by default unless explicitly first overriden by Magento class

Author: faizan-shk

app/code/Magento/Backend/Model/Menu.php

@@ -318,204 +318,4 @@ public function populateFromArray(array $data)
         }
         $this->exchangeArray($items);
     }
-
-    // Need to override and suppress return type deprecation warnings for php8 compatibility
-
-    /**
-     * @inheritDoc
-     * phpcs:disable Generic.CodeAnalysis.UselessOverridingMethod
-     */
-    public function offsetExists($key): bool
-    {
-        return parent::offsetExists($key);
-    }
-
-    /**
-     * @inheritDoc
-     */
-    #[\ReturnTypeWillChange]
-    public function offsetGet($key)
-    {
-        return parent::offsetGet($key);
-    }
-
-    /**
-     * @inheritDoc
-     */
-    #[\ReturnTypeWillChange]
-    public function offsetSet($key, $value)
-    {
-        parent::offsetSet($key, $value);
-    }
-
-    /**
-     * @inheritDoc
-     */
-    #[\ReturnTypeWillChange]
-    public function offsetUnset($key)
-    {
-        parent::offsetUnset($key);
-    }
-
-    /**
-     * @inheritDoc
-     */
-    public function count(): int
-    {
-        return parent::count();
-    }
-
-    /**
-     * @inheritDoc
-     */
-    #[\ReturnTypeWillChange]
-    public function append($value)
-    {
-        parent::append($value);
-    }
-
-    /**
-     * @inheritDoc
-     */
-    public function getArrayCopy(): array
-    {
-        return parent::getArrayCopy();
-    }
-
-    /**
-     * @inheritDoc
-     */
-    public function getFlags(): int
-    {
-        return parent::getFlags();
-    }
-
-    /**
-     * @inheritDoc
-     */
-    #[\ReturnTypeWillChange]
-    public function setFlags($flags)
-    {
-        parent::setFlags($flags);
-    }
-
-    /**
-     * @inheritDoc
-     *
-     * @phpstan-return void
-     */
-    #[\ReturnTypeWillChange]
-    public function asort($flags = SORT_REGULAR)
-    {
-        parent::asort($flags);
-    }
-
-    /**
-     * @inheritDoc
-     *
-     * @phpstan-return void
-     */
-    #[\ReturnTypeWillChange]
-    public function ksort($flags = SORT_REGULAR)
-    {
-        parent::ksort($flags);
-    }
-
-    /**
-     * @inheritDoc
-     */
-    #[\ReturnTypeWillChange]
-    public function uasort($callback)
-    {
-        parent::uasort($callback);
-    }
-
-    /**
-     * @inheritDoc
-     */
-    #[\ReturnTypeWillChange]
-    public function uksort($callback)
-    {
-        parent::uksort($callback);
-    }
-
-    /**
-     * @inheritDoc
-     */
-    public function exchangeArray($array): array
-    {
-        return parent::exchangeArray($array);
-    }
-
-    /**
-     * @inheritDoc
-     */
-    #[\ReturnTypeWillChange]
-    public function setIteratorClass($iteratorClass)
-    {
-        parent::setIteratorClass($iteratorClass);
-    }
-
-    /**
-     * @inheritDoc
-     *
-     * @phpstan-return void
-     */
-    #[\ReturnTypeWillChange]
-    public function natsort()
-    {
-        parent::natsort();
-    }
-
-    /**
-     * @inheritDoc
-     *
-     * @phpstan-return void
-     */
-    #[\ReturnTypeWillChange]
-    public function natcasesort()
-    {
-        parent::natcasesort();
-    }
-
-    /**
-     * @inheritDoc
-     */
-    public function __serialize(): array
-    {
-        return parent::__serialize();
-    }
-
-    /**
-     * @inheritDoc
-     */
-    #[\ReturnTypeWillChange]
-    public function __unserialize(array $data)
-    {
-        parent::__unserialize($data);
-    }
-
-    /**
-     * @inheritDoc
-     */
-    public function getIterator(): \ArrayIterator
-    {
-        return parent::getIterator();
-    }
-
-    /**
-     * @inheritDoc
-     */
-    public function getIteratorClass(): string
-    {
-        return parent::getIteratorClass();
-    }
-
-    /**
-     * @inheritDoc
-     */
-    public function __debugInfo(): array
-    {
-        return parent::__debugInfo();
-    }
 }

lib/internal/Magento/Framework/Interception/Code/Generator/Interceptor.php

@@ -72,7 +72,7 @@ protected function _getClassMethods()
         $reflectionClass = new \ReflectionClass($this->getSourceClassName());
         $publicMethods = $reflectionClass->getMethods(\ReflectionMethod::IS_PUBLIC);
         foreach ($publicMethods as $method) {
-            if ($this->isInterceptedMethod($method)) {
+            if (!$method->isInternal() && $this->isInterceptedMethod($method)) {
                 $methods[] = $this->_getMethodInfo($method);
             }
         }