Merge pull request #7981 from magento-performance/ACPT-860

[Performance] ACPT-860: Indexation time is calculated incorrectly

Author: adifucan

app/code/Magento/Indexer/Console/Command/IndexerReindexCommand.php

@@ -101,7 +101,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
                 $output->write($indexer->getTitle() . ' index ');
 
-                $startTime = microtime(true);
+                $startTime = new \DateTimeImmutable();
                 $indexerConfig = $this->getConfig()->getIndexer($indexer->getId());
                 $sharedIndex = $indexerConfig['shared_index'] ?? null;
 
@@ -112,10 +112,15 @@ protected function execute(InputInterface $input, OutputInterface $output)
                         $this->sharedIndexesComplete[] = $sharedIndex;
                     }
                 }
-                $resultTime = microtime(true) - $startTime;
+                $endTime = new \DateTimeImmutable();
+                $interval = $startTime->diff($endTime);
+                $days = $interval->format('%d');
+                $hours = $days > 0 ? $days * 24 + $interval->format('%H') : $interval->format('%H');
+                $minutes = $interval->format('%I');
+                $seconds = $interval->format('%S');
 
                 $output->writeln(
-                    __('has been rebuilt successfully in %time', ['time' => gmdate('H:i:s', (int) $resultTime)])
+                    __('has been rebuilt successfully in %1:%2:%3', $hours, $minutes, $seconds)
                 );
             } catch (\Throwable $e) {
                 $output->writeln('process error during indexation process:');
@@ -238,7 +243,9 @@ private function validateIndexerStatus(IndexerInterface $indexer)
      * Get config
      *
      * @return ConfigInterface
-     * @deprecated 100.1.0
+     * @deprecated 100.1.0 We don't recommend this approach anymore
+     * @see Add a new optional parameter to the constructor at the end of the arguments list instead
+     * and fetch the dependency using Magento\Framework\App\ObjectManager::getInstance() in the constructor body
      */
     private function getConfig()
     {
@@ -252,7 +259,9 @@ private function getConfig()
      * Get dependency info provider
      *
      * @return DependencyInfoProvider
-     * @deprecated 100.2.0
+     * @deprecated 100.2.0 We don't recommend this approach anymore
+     * @see Add a new optional parameter to the constructor at the end of the arguments list instead
+     * and fetch the dependency using Magento\Framework\App\ObjectManager::getInstance() in the constructor body
      */
     private function getDependencyInfoProvider()
     {

app/code/Magento/Indexer/Test/Unit/Console/Command/IndexerReindexCommandTest.php

@@ -8,13 +8,11 @@
 namespace Magento\Indexer\Test\Unit\Console\Command;
 
 use Magento\Framework\Console\Cli;
-use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\Indexer\Config\DependencyInfoProvider;
 use Magento\Framework\Indexer\ConfigInterface;
 use Magento\Framework\Indexer\IndexerInterface;
 use Magento\Framework\Indexer\IndexerRegistry;
 use Magento\Framework\Indexer\StateInterface;
-use Magento\Framework\Phrase;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager as ObjectManagerHelper;
 use Magento\Indexer\Console\Command\IndexerReindexCommand;
 use Magento\Indexer\Model\Config;
@@ -27,7 +25,7 @@
  */
 class IndexerReindexCommandTest extends AbstractIndexerCommandCommonSetup
 {
-    const STUB_INDEXER_NAME = 'Indexer Name';
+    private const STUB_INDEXER_NAME = 'Indexer Name';
     /**
      * Command being tested
      *
@@ -130,6 +128,11 @@ public function testExecuteAll()
             self::STUB_INDEXER_NAME . ' index has been rebuilt successfully in',
             $actualValue
         );
+        $this->assertMatchesRegularExpression(
+            '/' . self::STUB_INDEXER_NAME
+            . ' index has been rebuilt successfully in (?:(?:([01]?\d|2[0-3]):)?([0-5]?\d):)?([0-5]?\d)/m',
+            $actualValue
+        );
     }
 
     /**