ACP2E-1650:Create Shipment API

aplapana · aplapana · commit 6d2c954b1ab0 · 2023-04-01T08:36:36.000+03:00
- addressed CR feedback
diff --git a/app/code/Magento/Bundle/Model/Sales/Order/BundleOrderTypeValidator.php b/app/code/Magento/Bundle/Model/Sales/Order/BundleOrderTypeValidator.php
@@ -56,7 +56,7 @@ public function __construct(Request $request)
      */
     public function isValid($value): bool
     {
-        if (false === $this->canValidate()) {
+        if (false === $this->validationNeeded()) {
             return true;
         }
 
@@ -212,7 +212,7 @@ private function hasChildrenInShipping(ShipmentItemInterface $bundleItem, array
      *
      * @return bool
      */
-    private function canValidate(): bool
+    private function validationNeeded(): bool
     {
         return str_contains(strtolower($this->request->getUri()->getPath()), self::SHIPMENT_API_ROUTE);
     }

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ public function __construct(Request $request)`
`56`	`56`	`*/`
`57`	`57`	`public function isValid($value): bool`
`58`	`58`	`{`
`59`		`- if (false === $this->canValidate()) {`
	`59`	`+ if (false === $this->validationNeeded()) {`
`60`	`60`	`return true;`
`61`	`61`	`}`
`62`	`62`
`@@ -212,7 +212,7 @@ private function hasChildrenInShipping(ShipmentItemInterface $bundleItem, array`
`212`	`212`	`*`
`213`	`213`	`* @return bool`
`214`	`214`	`*/`
`215`		`- private function canValidate(): bool`
	`215`	`+ private function validationNeeded(): bool`
`216`	`216`	`{`
`217`	`217`	`return str_contains(strtolower($this->request->getUri()->getPath()), self::SHIPMENT_API_ROUTE);`
`218`	`218`	`}`