fixes after code review

Author: silinmykola

app/code/Magento/Catalog/Test/Unit/Model/Category/FileInfoTest.php

@@ -117,7 +117,7 @@ function ($arg) use ($baseDirectory, $pubDirectory) {
             ->willReturn('/a/b/c/pub/');
 
         $this->store->method('getBaseUrl')
-            ->willReturn('');
+            ->willReturn('https://example.com/');
 
         $this->model = new FileInfo(
             $this->filesystem,

app/code/Magento/Customer/Test/Unit/Model/Metadata/Form/FileTest.php

@@ -27,7 +27,7 @@
  */
 class FileTest extends AbstractFormTestCase
 {
-    const ENTITY_TYPE = 0;
+    public const ENTITY_TYPE = 0;
 
     /**
      * @var MockObject|EncoderInterface

app/code/Magento/Customer/Test/Unit/Model/Metadata/Form/MultiselectTest.php

@@ -195,27 +195,21 @@ protected function runOutputValueTest($value, $expected, $format)
             ->disableOriginalConstructor()
             ->setMethods(['getLabel', 'getValue'])
             ->getMockForAbstractClass();
-        $option1->expects($this->any())
-            ->method('getLabel')
+        $option1->method('getLabel')
             ->willReturn('fourteen');
-        $option1->expects($this->any())
-            ->method('getValue')
+        $option1->method('getValue')
             ->willReturn('14');
 
         $option2 = $this->getMockBuilder(OptionInterface::class)
             ->disableOriginalConstructor()
             ->setMethods(['getLabel', 'getValue'])
             ->getMockForAbstractClass();
-        $option2->expects($this->any())
-            ->method('getLabel')
+        $option2->method('getLabel')
             ->willReturn('some string');
-        $option2->expects($this->any())
-            ->method('getValue')
+        $option2->method('getValue')
             ->willReturn('some key');
 
-        $this->attributeMetadataMock->expects(
-            $this->any()
-        )->method(
+        $this->attributeMetadataMock->method(
             'getOptions'
         )->willReturn(
             [

app/code/Magento/MediaStorage/Test/Unit/App/MediaTest.php

@@ -37,9 +37,9 @@
  */
 class MediaTest extends TestCase
 {
-    const MEDIA_DIRECTORY = 'mediaDirectory';
-    const RELATIVE_FILE_PATH = 'test/file.png';
-    const CACHE_FILE_PATH = 'var';
+    public const MEDIA_DIRECTORY = 'mediaDirectory';
+    public const RELATIVE_FILE_PATH = 'test/file.png';
+    public const CACHE_FILE_PATH = 'var';
 
     /**
      * @var Media

lib/internal/Magento/Framework/Code/Test/Unit/Generator/EntityAbstractTest.php

@@ -15,28 +15,25 @@
 
 class EntityAbstractTest extends TestCase
 {
-    /**#@+
+    /**
      * Source and result class parameters
      */
-    const RESULT_FILE = 'MyResult/MyResult.php';
-
-    const RESULT_DIRECTORY = 'MyResult';
+    public const RESULT_FILE = 'MyResult/MyResult.php';
 
-    /**#@-*/
+    public const RESULT_DIRECTORY = 'MyResult';
 
     /**
      * Basic code generation directory
      */
-    const GENERATION_DIRECTORY = 'generation';
+    public const GENERATION_DIRECTORY = 'generation';
 
-    /**#@+
+    /**
      * Generated code before and after code style fix
      */
-    const SOURCE_CODE = "a = 1; b = array (); {\n\n some source code \n\n}";
+    public const SOURCE_CODE = "a = 1; b = array (); {\n\n some source code \n\n}";
 
-    const RESULT_CODE = "a = 1; b = array(); {\n some generated php code \n}";
+    public const RESULT_CODE = "a = 1; b = array(); {\n some generated php code \n}";
 
-    /**#@-*/
     /**
      * Model under test
      *

lib/internal/Magento/Framework/View/Test/Unit/Asset/Bundle/ManagerTest.php

@@ -120,11 +120,11 @@ public function testAddAssetWithExcludedFile()
             ->willReturn('source/file.min.js');
         $this->asset->expects($this->once())
             ->method('getPath')
-            ->willReturn('');
+            ->willReturn('some/path/to_file');
         $dirRead->expects($this->once())
             ->method('getAbsolutePath')
-            ->with('')
-            ->willReturn(true);
+            ->with('some/path/to_file')
+            ->willReturn('some/path/to_file');
         $this->filesystem->expects($this->once())
             ->method('getDirectoryRead')
             ->with(DirectoryList::APP)

lib/internal/Magento/Framework/View/Test/Unit/Element/Html/Link/CurrentTest.php

@@ -82,7 +82,7 @@ public function testIsCurrentIfIsset(): void
         $this->_urlBuilderMock
             ->method('getUrl')
             ->with($pathStub)
-            ->will($this->returnValue(''));
+            ->will($this->returnValue('http://example.com/'));
         $this->currentLink->setPath($pathStub);
         $this->currentLink->setCurrent(true);
         $this->assertTrue($this->currentLink->isCurrent());