ACP2E-4033: Issue mapping translated message to error code when placing order via GraphQL

Author: thiaramus

app/code/Magento/GraphQl/Helper/Error/AggregateExceptionMessageFormatter.php

@@ -59,8 +59,11 @@ public function getFormatted(
             }
         }
 
-        $message = $e->getCode() ? __($e->getMessage()) : $defaultMessage;
+        $messageText = $e->getCode() ? __($e->getMessage()) : $defaultMessage;
+        $messageWithPrefix = empty($messagePrefix)
+            ? $messageText
+            : __("$messagePrefix: %message", ['message' => $messageText]);
 
-        return new GraphQlInputException(__("$messagePrefix: %message", ['message' => $message]), $e, $e->getCode());
+        return new GraphQlInputException($messageWithPrefix, $e, $e->getCode());
     }
 }

app/code/Magento/GraphQl/Test/Unit/Helper/Error/AggregateExceptionMessageFormatterTest.php

@@ -118,7 +118,7 @@ public function testGetFormattedExceptionMessage(): void
         );
         $this->assertInstanceOf(GraphQlInputException::class, $exception);
         $this->assertSame($exceptionCode, $exception->getCode());
-        $this->assertSame($exceptionMessage, $exception->getMessage());
+        $this->assertSame($messagePrefix . ": " . $exceptionMessage, $exception->getMessage());
     }
 
     /**
@@ -127,7 +127,7 @@ public function testGetFormattedExceptionMessage(): void
     public function testGetFormattedDefaultMessage(): void
     {
         $exceptionMessage = 'exception message';
-        $messagePrefix = 'prefix';
+        $messagePrefix = '';
         $this->formatter->expects($this->once())
             ->method('getFormatted')
             ->willReturn(null);

dev/tests/integration/testsuite/Magento/PaypalGraphQl/Model/Resolver/Guest/PlaceOrderWithPayflowLinkTest.php

@@ -248,7 +248,7 @@ public function testResolveWithPayflowLinkDeclined(): void
         $resultCode = Payflowlink::RESPONSE_CODE_DECLINED_BY_FILTER;
         $exception = new RuntimeException(__('Declined response message from PayPal gateway')->render());
         //Exception message is transformed into more controlled message
-        $expectedErrorCode = 'UNDEFINED';
+        $expectedErrorCode = 'UNABLE_TO_PLACE_ORDER';
 
         $this->payflowRequest->method('setData')
             ->with(

dev/tests/integration/testsuite/Magento/PaypalGraphQl/Model/Resolver/Guest/PlaceOrderWithPaymentsAdvancedTest.php

@@ -208,7 +208,7 @@ public function testResolveWithPaymentAdvancedDeclined(): void
         $resultCode = Payflowlink::RESPONSE_CODE_DECLINED_BY_FILTER;
         $exception = new RuntimeException(__('Declined response message from PayPal gateway')->render());
         //Exception message is transformed into more controlled message
-        $expectedErrorCode = 'UNDEFINED';
+        $expectedErrorCode = 'UNABLE_TO_PLACE_ORDER';
 
         $this->paymentRequest->method('setData')
             ->with(