Skip to content

Commit 68753be

Browse files
AC-15182: PHPUnit 12 Upgrade | Refactoring helper classes
1 parent b23f953 commit 68753be

File tree

9 files changed

+55
-3
lines changed

9 files changed

+55
-3
lines changed

app/code/Magento/Backend/Test/Unit/Helper/SessionQuoteTestHelper.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,3 @@ public function getStoreId()
3535
return 1;
3636
}
3737
}
38-

app/code/Magento/Quote/Test/Unit/Helper/CartItemExtensionTestHelper.php

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,46 @@ public function setNegotiableQuoteItem($negotiableQuoteItem)
4848
$this->negotiableQuoteItem = $negotiableQuoteItem;
4949
return $this;
5050
}
51+
52+
/**
53+
* Get discounts
54+
*
55+
* @return mixed
56+
*/
57+
public function getDiscounts()
58+
{
59+
return null;
60+
}
61+
62+
/**
63+
* Set discounts
64+
*
65+
* @param mixed $discounts
66+
* @return $this
67+
*/
68+
public function setDiscounts($discounts)
69+
{
70+
return $this;
71+
}
72+
73+
/**
74+
* Get quote item test attribute
75+
*
76+
* @return mixed
77+
*/
78+
public function getQuoteItemTestAttribute()
79+
{
80+
return null;
81+
}
82+
83+
/**
84+
* Set quote item test attribute
85+
*
86+
* @param mixed $quoteItemTestAttribute
87+
* @return $this
88+
*/
89+
public function setQuoteItemTestAttribute($quoteItemTestAttribute)
90+
{
91+
return $this;
92+
}
5193
}

app/code/Magento/Quote/Test/Unit/Helper/CartItemTestHelper.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@
1818
*
1919
* This helper extends the concrete Item class to provide
2020
* test-specific functionality without dependency injection issues.
21+
* @SuppressWarnings(PHPMD.ExcessivePublicCount)
22+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
23+
* @SuppressWarnings(PHPMD.BooleanGetMethodName)
2124
*/
2225
class CartItemTestHelper extends Item
2326
{

lib/internal/Magento/Framework/Test/Unit/Helper/AbstractResourceTestHelper.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,4 +64,3 @@ public function getConnection()
6464
return null;
6565
}
6666
}
67-

lib/internal/Magento/Framework/Test/Unit/Helper/BuyRequestDataObjectTestHelper.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
* - setCustomPrice() for direct custom_price manipulation
2323
*
2424
* Used by tests that need precise control over data storage and retrieval.
25+
*
26+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
2527
*/
2628
class BuyRequestDataObjectTestHelper extends DataObject
2729
{

lib/internal/Magento/Framework/Test/Unit/Helper/JsonResultTestHelper.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
*
1919
* The production code calls setJsonData() for fluent interface, but doesn't use
2020
* the stored data, so we don't need to store it.
21+
*
22+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
2123
*/
2224
class JsonResultTestHelper implements ResultInterface
2325
{

lib/internal/Magento/Framework/Test/Unit/Helper/PageResultTestHelper.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
*
2020
* Production code calls: addHandle()->getLayout()->getBlock()
2121
* All three methods are required for the fluent interface chain.
22+
*
23+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
2224
*/
2325
class PageResultTestHelper implements ResultInterface
2426
{

lib/internal/Magento/Framework/Test/Unit/Helper/PageTestHelper.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
*
1616
* This helper extends the concrete Page class to provide
1717
* test-specific functionality without dependency injection issues.
18+
*
19+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
1820
*/
1921
class PageTestHelper extends Page
2022
{

lib/internal/Magento/Framework/Test/Unit/Helper/RequestInterfaceTestHelper.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414
*
1515
* This helper implements RequestInterface to provide
1616
* test-specific functionality without dependency injection issues.
17+
*
18+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
1719
*/
1820
class RequestInterfaceTestHelper implements RequestInterface
1921
{
@@ -195,4 +197,3 @@ public function getCookie($name, $default = null)
195197
return $default;
196198
}
197199
}
198-

0 commit comments

Comments
 (0)