BUG#AC-6666:resolved code review comments

Author: Rachana

app/code/Magento/CatalogGraphQl/Model/AttributesJoiner.php

@@ -10,6 +10,7 @@
 use GraphQL\Language\AST\FieldNode;
 use GraphQL\Language\AST\InlineFragmentNode;
 use GraphQL\Language\AST\NodeKind;
+use GraphQL\Language\AST\NodeList;
 use Magento\Eav\Model\Entity\Collection\AbstractCollection;
 use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
 
@@ -81,13 +82,13 @@ public function getQueryFields(FieldNode $fieldNode, ResolveInfo $resolveInfo):
     /**
      * Get an array of queried data.
      *
-     * @param array $query
+     * @param NodeList $query
      * @param ResolveInfo $resolveInfo
      * @return array
      */
-    public function getQueryData($query, $resolveInfo): array
+    public function getQueryData(NodeList $query, ResolveInfo $resolveInfo): array
     {
-        $selectedFields = $fragmentFields = [];
+        $selectedFields = $fragmentFields = $data = [];
         foreach ($query as $field) {
             if ($field->kind === NodeKind::INLINE_FRAGMENT) {
                 $fragmentFields[] = $this->addInlineFragmentFields($resolveInfo, $field);
@@ -107,9 +108,9 @@ public function getQueryData($query, $resolveInfo): array
                 $selectedFields[] = $field->name->value;
             }
         }
-        $data = [];
         $data['selectedFields'] = $selectedFields;
         $data['fragmentFields'] = $fragmentFields;
+
         return $data;
     }
 

app/code/Magento/CatalogGraphQl/Model/Resolver/Product/ProductFieldsSelector.php

@@ -55,7 +55,7 @@ public function getProductFieldsFromInfo(ResolveInfo $info, string $productNodeN
                 $queryFields = $this->attributesJoiner->getQueryFields($node, $info);
                 $fieldNames[] = $queryFields;
         }
-               $fieldNames = array_merge(...$fieldNames);
-               return $fieldNames;
+
+        return array_merge(...$fieldNames);
     }
 }