AC-465: Allow to configure input limit for RESTful endpoints

Author: arhiopterecs

app/code/Magento/Webapi/Controller/Soap/Request/Handler.php

@@ -18,7 +18,7 @@
 use Magento\Framework\Exception\AuthorizationException;
 use Magento\Framework\Reflection\DataObjectProcessor;
 use Magento\Framework\Webapi\ServiceInputProcessor;
-use Magento\Framework\Webapi\Request as SoapRequest;
+use Magento\Framework\Webapi\Request as WebapiRequest;
 use Magento\Framework\Webapi\Exception as WebapiException;
 use Magento\Framework\Webapi\Validator\EntityArrayValidator\InputArraySizeLimitValue;
 use Magento\Webapi\Controller\Rest\ParamsOverrider;
@@ -38,7 +38,7 @@ class Handler
     public const RESULT_NODE_NAME = 'result';
 
     /**
-     * @var \Magento\Framework\Webapi\Request
+     * @var WebapiRequest
      */
     protected $_request;
 
@@ -48,32 +48,32 @@ class Handler
     protected $_objectManager;
 
     /**
-     * @var \Magento\Webapi\Model\Soap\Config
+     * @var SoapConfig
      */
     protected $_apiConfig;
 
     /**
-     * @var \Magento\Framework\Webapi\Authorization
+     * @var Authorization
      */
     protected $authorization;
 
     /**
-     * @var \Magento\Framework\Api\SimpleDataObjectConverter
+     * @var SimpleDataObjectConverter
      */
     protected $_dataObjectConverter;
 
     /**
-     * @var \Magento\Framework\Webapi\ServiceInputProcessor
+     * @var ServiceInputProcessor
      */
     protected $serviceInputProcessor;
 
     /**
-     * @var \Magento\Framework\Reflection\DataObjectProcessor
+     * @var DataObjectProcessor
      */
     protected $_dataObjectProcessor;
 
     /**
-     * @var \Magento\Framework\Reflection\MethodsMap
+     * @var MethodsMap
      */
     protected $methodsMapProcessor;
 
@@ -90,7 +90,7 @@ class Handler
     /**
      * Initialize dependencies.
      *
-     * @param SoapRequest $request
+     * @param WebapiRequest $request
      * @param ObjectManagerInterface $objectManager
      * @param SoapConfig $apiConfig
      * @param Authorization $authorization
@@ -100,9 +100,10 @@ class Handler
      * @param MethodsMap $methodsMapProcessor
      * @param ParamsOverrider|null $paramsOverrider
      * @param InputArraySizeLimitValue|null $inputArraySizeLimitValue
+     * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
-        SoapRequest $request,
+        WebapiRequest  $request,
         ObjectManagerInterface $objectManager,
         SoapConfig $apiConfig,
         Authorization $authorization,

app/code/Magento/WebapiAsync/Controller/Rest/Asynchronous/InputParamsResolver.php

@@ -70,8 +70,8 @@ class InputParamsResolver
      * @param Router $router
      * @param RequestValidator $requestValidator
      * @param WebapiInputParamsResolver $inputParamsResolver
-     * @param InputArraySizeLimitValue|null $inputArraySizeLimitValue
      * @param bool $isBulk
+     * @param InputArraySizeLimitValue|null $inputArraySizeLimitValue
      */
     public function __construct(
         RestRequest $request,

lib/internal/Magento/Framework/Webapi/Test/Unit/ServiceInputProcessorTest.php

@@ -84,11 +84,6 @@ class ServiceInputProcessorTest extends TestCase
      */
     private $defaultPageSizeSetter;
 
-    /**
-     * @var InputArraySizeLimitValue
-     */
-    private $inputArraySizeLimitValue;
-
     /**
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
@@ -173,7 +168,7 @@ function () use ($objectManager) {
             ->disableOriginalConstructor()
             ->getMock();
 
-        $this->inputArraySizeLimitValue = $this->createMock(InputArraySizeLimitValue::class);
+        $inputArraySizeLimitValue = $this->createMock(InputArraySizeLimitValue::class);
 
         $this->defaultPageSizeSetter = self::getMockBuilder(DefaultPageSizeSetter::class)
             ->disableOriginalConstructor()
@@ -191,11 +186,10 @@ function () use ($objectManager) {
                 'serviceInputValidator' => new EntityArrayValidator(
                     50,
                     $this->inputLimitConfig,
-                    $this->inputArraySizeLimitValue
+                    $inputArraySizeLimitValue
                 ),
                 'defaultPageSizeSetter' => $this->defaultPageSizeSetter,
-                'defaultPageSize' => 123,
-                'inputArraySizeLimitValue' => $this->inputArraySizeLimitValue
+                'defaultPageSize' => 123
             ]
         );