LYNX-699 Review feedback fixed

Author: cod40403

app/code/Magento/SalesGraphQl/Model/Resolver/OrderTotal.php

@@ -89,18 +89,14 @@ public function resolve(
      */
     private function getAllAppliedTaxesOnOrders(OrderInterface $order): array
     {
-        $orderTaxDetails = $this->orderTaxManagement->getOrderTaxDetails($order->getEntityId());
-        $appliedTaxes = $orderTaxDetails->getAppliedTaxes();
-        $allAppliedTaxOnOrders = [];
-        foreach ($appliedTaxes as $taxIndex => $appliedTaxesData) {
-            $allAppliedTaxOnOrders[$taxIndex] = [
+        return array_map(
+            fn($appliedTaxesData) => [
                 'title' => $appliedTaxesData->getDataByKey('title'),
                 'percent' => $appliedTaxesData->getDataByKey('percent'),
                 'amount' => $appliedTaxesData->getDataByKey('amount'),
-            ];
-        }
-
-        return $allAppliedTaxOnOrders;
+            ],
+            $this->orderTaxManagement->getOrderTaxDetails($order->getEntityId())->getAppliedTaxes()
+        );
     }
 
     /**

dev/tests/api-functional/testsuite/Magento/GraphQl/Sales/PlaceOrderTaxTitleTest.php

@@ -83,22 +83,47 @@ protected function setUp(): void
     public function testTaxTitleOnPlaceOrder(): void
     {
         $maskedQuoteId = $this->fixtures->get('quoteIdMask')->getMaskedId();
-        $headerMap = $this->getCustomerAuthHeaders($this->fixtures->get('customer')->getEmail());
+        $customerAuthHeaders = $this->getCustomerAuthHeaders($this->fixtures->get('customer')->getEmail());
 
         //set shipping address to cart (save_in_address_book => true)
-        $this->graphQlMutation($this->getSetShippingAddressOnCartMutation($maskedQuoteId), [], '', $headerMap);
+        $this->graphQlMutation(
+            $this->getSetShippingAddressOnCartMutation($maskedQuoteId),
+            [],
+            '',
+            $customerAuthHeaders
+        );
 
         //set billing address to cart same as shipping
-        $this->graphQlMutation($this->getBillingAddressMutationSameAsShipping($maskedQuoteId), [], '', $headerMap);
+        $this->graphQlMutation(
+            $this->getBillingAddressMutationSameAsShipping($maskedQuoteId),
+            [],
+            '',
+            $customerAuthHeaders
+        );
 
         //set shipping method on cart
-        $this->graphQlMutation($this->getShippingMethodMutation($maskedQuoteId), [], '', $headerMap);
+        $this->graphQlMutation(
+            $this->getShippingMethodMutation($maskedQuoteId),
+            [],
+            '',
+            $customerAuthHeaders
+        );
 
         //set payment method on cart
-        $this->graphQlMutation($this->getPaymentMethodMutation($maskedQuoteId), [], '', $headerMap);
+        $this->graphQlMutation(
+            $this->getPaymentMethodMutation($maskedQuoteId),
+            [],
+            '',
+            $customerAuthHeaders
+        );
 
         //place order
-        $orderResponse = $this->graphQlMutation($this->getPlaceOrderMutation($maskedQuoteId), [], '', $headerMap);
+        $orderResponse = $this->graphQlMutation(
+            $this->getPlaceOrderMutation($maskedQuoteId),
+            [],
+            '',
+            $customerAuthHeaders
+        );
 
         //assert tax title
         self::assertNotNull($orderResponse['placeOrder']['orderV2']['total']['taxes'][0]['title']);