Merge branch 'MC-37070' into 2.4-develop-sidecar-pr4

Author: ysapiga

dev/tests/integration/testsuite/Magento/Catalog/Model/Product/Gallery/UpdateHandlerTest.php

@@ -8,13 +8,15 @@
 
 namespace Magento\Catalog\Model\Product\Gallery;
 
+use Magento\Catalog\Api\Data\ProductAttributeMediaGalleryEntryInterface;
 use Magento\Catalog\Api\Data\ProductInterface;
 use Magento\Catalog\Api\ProductRepositoryInterface;
 use Magento\Catalog\Model\Product;
 use Magento\Catalog\Model\Product\Media\Config;
 use Magento\Catalog\Model\ResourceModel\Product as ProductResource;
 use Magento\Catalog\Model\ResourceModel\Product\Gallery;
 use Magento\Framework\App\Filesystem\DirectoryList;
+use Magento\Framework\EntityManager\MetadataPool;
 use Magento\Framework\Filesystem;
 use Magento\Framework\Filesystem\Directory\WriteInterface;
 use Magento\Framework\ObjectManagerInterface;
@@ -84,11 +86,17 @@ class UpdateHandlerTest extends \PHPUnit\Framework\TestCase
      * @var StoreManagerInterface
      */
     private $storeManager;
+
     /**
      * @var int
      */
     private $currentStoreId;
 
+    /**
+     * @var MetadataPool
+     */
+    private $metadataPool;
+
     /**
      * @inheritdoc
      */
@@ -108,6 +116,7 @@ protected function setUp(): void
         $this->mediaDirectory = $this->objectManager->get(Filesystem::class)
             ->getDirectoryWrite(DirectoryList::MEDIA);
         $this->mediaDirectory->writeFile($this->fileName, 'Test');
+        $this->metadataPool = $this->objectManager->get(MetadataPool::class);
     }
 
     /**
@@ -351,6 +360,23 @@ public function testExecuteWithTwoImagesOnStoreView(): void
         }
     }
 
+    /**
+     * @magentoDataFixture Magento/Catalog/_files/product_with_image.php
+     * @magentoDataFixture Magento/Catalog/_files/second_product_simple.php
+     *
+     * @return void
+     */
+    public function testDeleteSharedImage(): void
+    {
+        $product = $this->getProduct(null, 'simple');
+        $this->duplicateMediaGalleryForProduct('/m/a/magento_image.jpg', 'simple2');
+        $secondProduct = $this->getProduct(null, 'simple2');
+        $this->updateHandler->execute($this->prepareRemoveImage($product), []);
+        $product = $this->getProduct(null, 'simple');
+        $this->assertEmpty($product->getMediaGalleryImages()->getItems());
+        $this->checkProductImageExist($secondProduct, '/m/a/magento_image.jpg');
+    }
+
     /**
      * @inheritdoc
      */
@@ -371,11 +397,13 @@ protected function tearDown(): void
      * Returns current product.
      *
      * @param int|null $storeId
+     * @param string|null $sku
      * @return ProductInterface|Product
      */
-    private function getProduct(?int $storeId = null): ProductInterface
+    private function getProduct(?int $storeId = null, ?string $sku = null): ProductInterface
     {
-        return $this->productRepository->get('simple', false, $storeId, true);
+        $sku = $sku ?: 'simple';
+        return $this->productRepository->get($sku, false, $storeId, true);
     }
 
     /**
@@ -464,6 +492,86 @@ public function testDeleteWithMultiWebsites(): void
         $this->assertArrayNotHasKey($secondStoreId, $imageRolesPerStore);
     }
 
+    /**
+     * Check product image link and product image exist
+     *
+     * @param ProductInterface $product
+     * @param string $imagePath
+     * @return void
+     */
+    private function checkProductImageExist(ProductInterface $product, string $imagePath): void
+    {
+        $productImageItem = $product->getMediaGalleryImages()->getFirstItem();
+        $this->assertEquals($imagePath, $productImageItem->getFile());
+        $productImageFile = $productImageItem->getPath();
+        $this->assertNotEmpty($productImageFile);
+        $this->assertTrue($this->mediaDirectory->getDriver()->isExists($productImageFile));
+        $this->fileName = $productImageFile;
+    }
+
+    /**
+     * Prepare the product to remove image
+     *
+     * @param ProductInterface $product
+     * @return ProductInterface
+     */
+    private function prepareRemoveImage(ProductInterface $product): ProductInterface
+    {
+        $item = $product->getMediaGalleryImages()->getFirstItem();
+        $item->setRemoved('1');
+        $galleryData = [
+            'images' => [
+                (int)$item->getValueId() => $item->getData(),
+            ]
+        ];
+        $product->setData(ProductInterface::MEDIA_GALLERY, $galleryData);
+        $product->setStoreId(0);
+
+        return $product;
+    }
+
+    /**
+     * Duplicate media gallery entries for a product
+     *
+     * @param string $imagePath
+     * @param string $productSku
+     * @return void
+     */
+    private function duplicateMediaGalleryForProduct(string $imagePath, string $productSku): void
+    {
+        $product = $this->getProduct(null, $productSku);
+        $connect = $this->galleryResource->getConnection();
+        $select = $connect->select()->from($this->galleryResource->getMainTable())->where('value = ?', $imagePath);
+        $result = $connect->fetchRow($select);
+        $value_id = $result['value_id'];
+        unset($result['value_id']);
+        $rows = [
+            'attribute_id' => $result['attribute_id'],
+            'value' => $result['value'],
+            ProductAttributeMediaGalleryEntryInterface::MEDIA_TYPE => $result['media_type'],
+            ProductAttributeMediaGalleryEntryInterface::DISABLED => $result['disabled'],
+        ];
+        $connect->insert($this->galleryResource->getMainTable(), $rows);
+        $select = $connect->select()
+            ->from($this->galleryResource->getTable(Gallery::GALLERY_VALUE_TABLE))
+            ->where('value_id = ?', $value_id);
+        $result = $connect->fetchRow($select);
+        $newValueId = (int)$value_id + 1;
+        $metadata = $this->metadataPool->getMetadata(ProductInterface::class);
+        $linkField = $metadata->getLinkField();
+        $rows = [
+            'value_id' => $newValueId,
+            'store_id' => $result['store_id'],
+            ProductAttributeMediaGalleryEntryInterface::LABEL => $result['label'],
+            ProductAttributeMediaGalleryEntryInterface::POSITION => $result['position'],
+            ProductAttributeMediaGalleryEntryInterface::DISABLED => $result['disabled'],
+            $linkField => $product->getData($linkField),
+        ];
+        $connect->insert($this->galleryResource->getTable(Gallery::GALLERY_VALUE_TABLE), $rows);
+        $rows = ['value_id' => $newValueId, $linkField => $product->getData($linkField)];
+        $connect->insert($this->galleryResource->getTable(Gallery::GALLERY_VALUE_TO_ENTITY_TABLE), $rows);
+    }
+
     /**
      * @param Product $product
      * @param array $roles