Fixed PDO statement with tests for compatibility with PHP >= 8.0

Author: andrewbess

lib/internal/Magento/Framework/DB/Statement/Pdo/Mysql.php

@@ -14,7 +14,6 @@
  */
 class Mysql extends \Zend_Db_Statement_Pdo
 {
-
     /**
      * Executes statement with binding values to it. Allows transferring specific options to DB driver.
      *
@@ -40,7 +39,7 @@ public function _executeWithBinding(array $params)
         // Separate array with values, as they are bound by reference
         foreach ($params as $name => $param) {
             $dataType = \PDO::PARAM_STR;
-            $length = null;
+            $length = is_string($param) ? strlen($param) : 0;
             $driverOptions = null;
 
             if ($param instanceof Parameter) {
@@ -88,7 +87,7 @@ public function _execute(array $params = null)
             return $this->_executeWithBinding($params);
         } else {
             return $this->tryExecute(function () use ($params) {
-                return $params !== null ? $this->_stmt->execute($params) : $this->_stmt->execute();
+                return !empty($params) ? $this->_stmt->execute($params) : $this->_stmt->execute();
             });
         }
     }

lib/internal/Magento/Framework/DB/Test/Unit/DB/Statement/MysqlTest.php

@@ -114,8 +114,8 @@ public function testExecuteWhenParamsAsParameterObject()
     {
         $param1 = $this->createMock(Parameter::class);
         $param1Value = 'SomeValue';
-        $param1DataType = 'dataType';
-        $param1Length = '9';
+        $param1DataType = \PDO::PARAM_STR;
+        $param1Length = 9;
         $param1DriverOptions = 'some driver options';
         $param1->expects($this->once())
             ->method('getIsBlob')
@@ -145,7 +145,7 @@ public function testExecuteWhenParamsAsParameterObject()
             ->method('bindParam')
             ->withConsecutive(
                 [':param1', $param1Value, $param1DataType, $param1Length, $param1DriverOptions],
-                [':param2', 'value2', \PDO::PARAM_STR, null, null]
+                [':param2', 'value2', \PDO::PARAM_STR, 6, null]
             );
         $this->pdoStatementMock->expects($this->once())
             ->method('execute');