Fixed Backward compability & other review comments

Author: engcom-Dash

app/code/Magento/Checkout/Model/Sidebar.php

@@ -135,7 +135,7 @@ protected function normalize($itemQty)
             }
 
             $filter = new LocalizedToNormalized(
-                ['locale' => $this->resolver->getLocale()]
+                ['locale' => $this->resolver->getLocale(), 'decimal_style' => NumberFormatter::DECIMAL]
             );
             return $filter->filter((string)$itemQty);
         }

app/code/Magento/Checkout/Test/Unit/Model/SidebarTest.php

@@ -148,8 +148,12 @@ public function testRemoveQuoteItem()
      *
      * @dataProvider dataProviderUpdateQuoteItem
      */
-    public function testUpdateQuoteItem($locale, $itemId, $expectedItemQty, $itemQty)
-    {
+    public function testUpdateQuoteItem(
+        string $locale,
+        int|string $itemId,
+        int|string|float $expectedItemQty,
+        int|string|float $itemQty
+    ) {
         $this->resolverMock->expects($this->once())
             ->method('getLocale')
             ->willReturn($locale);
@@ -188,7 +192,7 @@ public function testUpdateQuoteItemWithZeroQty()
     /**
      * @return array
      */
-    public static function dataProviderUpdateQuoteItem()
+    public static function dataProviderUpdateQuoteItem(): array
     {
         return [
             //locale, itemId, expectedItemQty, ItemQty

lib/internal/Magento/Framework/Filter/LocalizedToNormalized.php

@@ -20,7 +20,8 @@ class LocalizedToNormalized implements FilterInterface
     protected $_options = [
         'locale' => null,
         'date_format' => null,
-        'precision' => null
+        'precision' => null,
+        'decimal_style' => null
     ];
 
     /**
@@ -67,8 +68,17 @@ public function setOptions(?array $options = null)
     public function filter($value)
     {
         if (is_numeric($value)) {
+
+            if (filter_var($value, FILTER_VALIDATE_INT) !== false) {
+                $value = (int)$value;
+            } elseif (filter_var($value, FILTER_VALIDATE_FLOAT) !== false) {
+                $value = (float)$value;
+            }
             $numberParse = new NumberParse(
-                $this->_options['locale']
+                $this->_options['locale'],
+                empty($this->_options['decimal_style'])
+                    ? NumberFormatter::PATTERN_DECIMAL
+                    : $this->_options['decimal_style']
             );
             return (string)$numberParse->filter($value);
         } elseif ($this->_options['date_format'] === null && strpos($value, ':') !== false) {

lib/internal/Magento/Framework/Filter/Test/Unit/LocalizedToNormalizedTest.php

@@ -21,7 +21,7 @@ class LocalizedToNormalizedTest extends TestCase
      *
      * @dataProvider localizedToNormalizedDataProvider
      */
-    public function testLocalizedToNormalized($value, $options, $expectedValue)
+    public function testLocalizedToNormalized(string $value, array $options, string|array $expectedValue)
     {
         $filter = new LocalizedToNormalized($options);
         $this->assertEquals($expectedValue, $filter->filter($value));
@@ -30,16 +30,16 @@ public function testLocalizedToNormalized($value, $options, $expectedValue)
     /**
      * @return array
      */
-    public static function localizedToNormalizedDataProvider()
+    public static function localizedToNormalizedDataProvider(): array
     {
-        
         return [
             '1' => [
                 "0.5",
                 [
                     'locale' => 'nl',
                     'date_format' => null,
-                    'precision' => null
+                    'precision' => null,
+                    'decimal_style' => null
                 ],
                 "0.5"
             ],
@@ -48,7 +48,8 @@ public static function localizedToNormalizedDataProvider()
                 [
                     'locale' => 'en',
                     'date_format' => null,
-                    'precision' => null
+                    'precision' => null,
+                    'decimal_style' => NumberFormatter::PATTERN_DECIMAL
                 ],
                 "0.5"
             ],