ACP2E-3710: updated mftf to avoid flakiness

Author: alzota

app/code/Magento/GroupedProduct/Test/Mftf/ActionGroup/StorefrontValidateThreeGroupedProductQtyErrorMessageActionGroup.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!--
  /**
-  * Copyright 2011 Adobe
+  * Copyright 2024 Adobe
   * All Rights Reserved.
   */
 -->
@@ -13,12 +13,12 @@
             <description>Validates Child Products Quantities Input Error Messages are displaying</description>
         </annotations>
         <arguments>
-            <argument name="firstProductIndex" type="string" defaultValue="1"/>
-            <argument name="secondProductIndex" type="string" defaultValue="2"/>
-            <argument name="thirdProductIndex" type="string" defaultValue="3"/>
+            <argument name="firstProductId" type="string"/>
+            <argument name="secondProductId" type="string"/>
+            <argument name="thirdProductId" type="string" />
         </arguments>
-        <dontSeeElement selector="{{StorefrontProductInfoMainSection.groupedProductsAssociatedProductQuantityMageError(firstProductIndex)}}" stepKey="checkingInputValidationErrorMessageForFirstProduct"/>
-        <seeElement selector="{{StorefrontProductInfoMainSection.groupedProductsAssociatedProductQuantityMageError(secondProductIndex)}}" stepKey="checkingInputValidationErrorMessageForSecondProduct"/>
-        <dontSeeElement selector="{{StorefrontProductInfoMainSection.groupedProductsAssociatedProductQuantityMageError(thirdProductIndex)}}" stepKey="checkingInputValidationErrorMessageForThirdProduct"/>
+        <dontSeeElement selector="{{StorefrontProductInfoMainSection.groupedProductOptionQtyError(firstProductId)}}" stepKey="checkingInputValidationErrorMessageForFirstProduct"/>
+        <seeElement selector="{{StorefrontProductInfoMainSection.groupedProductOptionQtyError(secondProductId)}}" stepKey="checkingInputValidationErrorMessageForSecondProduct"/>
+        <dontSeeElement selector="{{StorefrontProductInfoMainSection.groupedProductOptionQtyError(thirdProductId)}}" stepKey="checkingInputValidationErrorMessageForThirdProduct"/>
     </actionGroup>
 </actionGroups>

app/code/Magento/GroupedProduct/Test/Mftf/Section/StorefrontProductInfoMainSection.xml

@@ -14,7 +14,6 @@
         <element name="groupedProductsAssociatedProductName" type="text" parameterized="true" selector="#super-product-table tbody tr:nth-of-type({{index}}) .product-item-name"/>
         <element name="groupedProductsAssociatedProductPrice" type="text" parameterized="true" selector="#super-product-table tbody tr:nth-of-type({{index}}) .price"/>
         <element name="groupedProductsAssociatedProductQuantity" type="input" parameterized="true" selector="#super-product-table tbody tr:nth-of-type({{index}}) input.qty"/>
-        <element name="groupedProductsAssociatedProductQuantityMageError" type="input" parameterized="true" selector="#super-product-table tr:nth-of-type({{index}}) input.mage-error"/>
         <element name="groupedProductOptions" type="input" selector="//td//strong[text()='{{productName}}']" parameterized="true"/>
         <element name="groupedProductOptionQtyError" type="text" selector="//*[@id='super_group[{{productId}}]-error']" parameterized="true"/>
     </section>

app/code/Magento/GroupedProduct/Test/Mftf/Test/StoreFrontValidateGroupedProductQuantityInputErrorMessageTest.xml

@@ -35,15 +35,12 @@
                 <requiredEntity createDataKey="product"/>
                 <requiredEntity createDataKey="simple3"/>
             </updateData>
-            <actionGroup ref="CliIndexerReindexActionGroup" stepKey="runIndex">
-                <argument name="indices" value=""/>
-            </actionGroup>
         </before>
         <after>
+            <deleteData createDataKey="product" stepKey="deleteGroupedProduct"/>
             <deleteData createDataKey="simple1" stepKey="deleteSimple1"/>
             <deleteData createDataKey="simple2" stepKey="deleteSimple2"/>
             <deleteData createDataKey="simple3" stepKey="deleteSimple3"/>
-            <deleteData createDataKey="product" stepKey="deleteGroupedProduct"/>
         </after>
         <actionGroup ref="StorefrontAddThreeGroupedProductToTheCartActionGroup" stepKey="enterSimpleProductsQty">
             <argument name="urlKey" value="$$product.custom_attributes[url_key]$$" />
@@ -54,6 +51,10 @@
             <argument name="qty2" value="-10"/>
             <argument name="qty3" value="5"/>
         </actionGroup>
-        <actionGroup ref="StorefrontValidateThreeGroupedProductQtyErrorMessageActionGroup" stepKey="verifyQtyInputErrorMessage" />
+        <actionGroup ref="StorefrontValidateThreeGroupedProductQtyErrorMessageActionGroup" stepKey="verifyQtyInputErrorMessage">
+            <argument name="firstProductId" value="$simple1.id$"/>
+            <argument name="secondProductId" value="$simple2.id$"/>
+            <argument name="thirdProductId" value="$simple3.id$"/>
+        </actionGroup>
     </test>
 </tests>