ACP2E-3373: [Cloud] Admin Panel exposed to the public - Custom Admin URL not effective

dhorytskyi · dhorytskyi · commit 5af4ff713d2b · 2024-10-28T23:31:08.000-05:00
diff --git a/app/code/Magento/Backend/App/Area/FrontNameResolver.php b/app/code/Magento/Backend/App/Area/FrontNameResolver.php
@@ -141,11 +141,11 @@ public function isHostBackend()
             return false;
         }
 
-        $configuredPort = $this->uri->getPort() ?: ($this->standardPorts[$this->uri->getScheme()] ?? '');
+        $configuredPort = $this->uri->getPort() ?: ($this->standardPorts[$this->uri->getScheme()] ?? '80');
         $configuredHost = $this->uri->getHost() . ':' . $configuredPort;
         $host = $this->request->getServer('HTTP_HOST');
         if (!str_contains($host, ':')) {
-            $host .= ':' . ($this->standardPorts[$this->request->getServer('REQUEST_SCHEME')] ?? '');
+            $host .= ':' . ($this->standardPorts[$this->request->getServer('REQUEST_SCHEME')] ?? '80');
         }
 
         return strcasecmp($configuredHost, $host) === 0;

Original file line number	Diff line number	Diff line change
`@@ -141,11 +141,11 @@ public function isHostBackend()`
`141`	`141`	`return false;`
`142`	`142`	`}`
`143`	`143`
`144`		`- $configuredPort = $this->uri->getPort() ?: ($this->standardPorts[$this->uri->getScheme()] ?? '');`
	`144`	`+ $configuredPort = $this->uri->getPort() ?: ($this->standardPorts[$this->uri->getScheme()] ?? '80');`
`145`	`145`	`$configuredHost = $this->uri->getHost() . ':' . $configuredPort;`
`146`	`146`	`$host = $this->request->getServer('HTTP_HOST');`
`147`	`147`	`if (!str_contains($host, ':')) {`
`148`		`- $host .= ':' . ($this->standardPorts[$this->request->getServer('REQUEST_SCHEME')] ?? '');`
	`148`	`+ $host .= ':' . ($this->standardPorts[$this->request->getServer('REQUEST_SCHEME')] ?? '80');`
`149`	`149`	`}`
`150`	`150`
`151`	`151`	`return strcasecmp($configuredHost, $host) === 0;`