ACP2E-2204: Price indexing performance gradually degrades overtime

- trying to drop tables instead

Author: aplapana

app/code/Magento/Catalog/Model/Indexer/Product/Price/Action/Full.php

@@ -259,8 +259,12 @@ private function reindexByBatches(
         array $dimensions,
         string $typeId
     ): void {
+        $i = 0;
         foreach ($this->getBatchesForIndexer($typeId) as $batch) {
+            $start = microtime(true);
             $this->reindexByBatchWithDimensions($priceIndexer, $batch, $dimensions);
+            $time_elapsed_secs = microtime(true) - $start;
+            echo $i++."--> $time_elapsed_secs secs".PHP_EOL;
         }
     }
 
@@ -311,7 +315,6 @@ private function reindexByBatchWithDimensions(
         if (!empty($entityIds)) {
             $this->dimensionTableMaintainer->createMainTmpTable($dimensions);
             $temporaryTable = $this->dimensionTableMaintainer->getMainTmpTable($dimensions);
-
             $priceIndexer->executeByDimensions($dimensions, \SplFixedArray::fromArray($entityIds, false));
 
             // Sync data from temp table to index table
@@ -488,6 +491,7 @@ private function moveDataFromReplicaTableToReplicaTables(array $dimensions): voi
      * Retrieves the index table that should be used
      *
      * @deprecated 102.0.6
+     * @see only used in another deprecated method: _copyRelationIndexData
      */
     protected function getIndexTargetTable(): string
     {

app/code/Magento/Catalog/Test/Unit/Model/Indexer/Product/Price/CustomOptionPriceModifierTest.php

@@ -92,7 +92,8 @@ public function testModifyPrice(): void
         $connection->expects($this->exactly(2))->method('delete');
         $connection->expects($this->any())->method('select')->willReturn($select);
         $connection->expects($this->any())->method('fetchRow')->willReturn(['exists']);
-        $connection->expects($this->exactly(6))->method('query');
+        $connection->expects($this->exactly(4))->method('query');
+        $connection->expects($this->exactly(2))->method('dropTemporaryTable');
         $this->resource->expects($this->any())->method('getConnection')->willReturn($connection);
         $this->resource->expects($this->any())->method('getTableName')->willReturn('table');
         $this->tableStrategy->expects($this->any())