Fixes incorrect classes being referenced in Magento modules.

Author: hostep

app/code/Magento/Catalog/Model/ProductRepository.php

@@ -813,7 +813,7 @@ private function getCollectionProcessor()
     {
         if (!$this->collectionProcessor) {
             $this->collectionProcessor = \Magento\Framework\App\ObjectManager::getInstance()->get(
-                // phpstan:ignore "Class Magento\Catalog\Model\Api\SearchCriteria\ProductCollectionProcessor not found."
+                // @phpstan-ignore-next-line - this is a virtual type defined in di.xml
                 \Magento\Catalog\Model\Api\SearchCriteria\ProductCollectionProcessor::class
             );
         }

app/code/Magento/CatalogInventory/Model/Indexer/Stock/Action/Full.php

@@ -12,7 +12,6 @@
 
 use Magento\Catalog\Api\Data\ProductInterface;
 use Magento\Catalog\Model\ResourceModel\Indexer\ActiveTableSwitcher;
-use Magento\CatalogInventory\Model\Indexer\Stock\BatchSizeManagement;
 use Magento\CatalogInventory\Model\ResourceModel\Indexer\Stock\DefaultStock;
 use Magento\Framework\App\ResourceConnection;
 use Magento\CatalogInventory\Model\ResourceModel\Indexer\StockFactory;
@@ -125,7 +124,7 @@ public function __construct(
         $this->metadataPool = $metadataPool ?: ObjectManager::getInstance()->get(MetadataPool::class);
         $this->batchProvider = $batchProvider ?: ObjectManager::getInstance()->get(BatchProviderInterface::class);
         $this->batchSizeManagement = $batchSizeManagement ?: ObjectManager::getInstance()->get(
-            BatchSizeManagement::class
+            BatchSizeManagementInterface::class
         );
         $this->batchRowsCount = $batchRowsCount;
         $this->activeTableSwitcher = $activeTableSwitcher ?: ObjectManager::getInstance()

app/code/Magento/CatalogRule/Model/ResourceModel/Rule.php

@@ -129,7 +129,7 @@ public function __construct(
         $this->priceCurrency = $priceCurrency;
         $this->entityManager = $entityManager ?? ObjectManager::getInstance()->get(EntityManager::class);
         $this->_associatedEntitiesMap = $associatedEntityMap ?? ObjectManager::getInstance()
-            // phpstan:ignore this is a virtual class
+            // @phpstan-ignore-next-line - this is a virtual type defined in di.xml
             ->get(\Magento\CatalogRule\Model\ResourceModel\Rule\AssociatedEntityMap::class)
             ->getData();
         parent::__construct($context, $connectionName);

app/code/Magento/CatalogRule/Model/ResourceModel/Rule/Collection.php

@@ -164,7 +164,7 @@ private function getAssociatedEntitiesMap()
     {
         if (!$this->_associatedEntitiesMap) {
             $this->_associatedEntitiesMap = \Magento\Framework\App\ObjectManager::getInstance()
-                // phpstan:ignore
+                // @phpstan-ignore-next-line - this is a virtual type defined in di.xml
                 ->get(\Magento\CatalogRule\Model\ResourceModel\Rule\AssociatedEntityMap::class)
                 ->getData();
         }

app/code/Magento/Cms/Model/PageRepository.php

@@ -289,9 +289,8 @@ public function deleteById($pageId)
     private function getCollectionProcessor()
     {
         if (!$this->collectionProcessor) {
-            // phpstan:ignore "Class Magento\Cms\Model\Api\SearchCriteria\PageCollectionProcessor not found."
-            $this->collectionProcessor = ObjectManager::getInstance()
-                ->get(PageCollectionProcessor::class);
+            // @phpstan-ignore-next-line - this is a virtual type defined in di.xml
+            $this->collectionProcessor = ObjectManager::getInstance()->get(PageCollectionProcessor::class);
         }
         return $this->collectionProcessor;
     }

app/code/Magento/Paypal/Observer/AddPaypalShortcutsObserver.php

@@ -57,9 +57,13 @@ public function execute(EventObserver $observer)
             SmartButton::class => PaypalConfig::METHOD_WPS_EXPRESS,
             \Magento\Paypal\Block\Express\Shortcut::class => PaypalConfig::METHOD_WPP_EXPRESS,
             \Magento\Paypal\Block\Bml\Shortcut::class => PaypalConfig::METHOD_WPP_EXPRESS,
+            // @phpstan-ignore-next-line - this is a virtual type defined in di.xml
             \Magento\Paypal\Block\WpsExpress\Shortcut::class => PaypalConfig::METHOD_WPS_EXPRESS,
+            // @phpstan-ignore-next-line - this is a virtual type defined in di.xml
             \Magento\Paypal\Block\WpsBml\Shortcut::class => PaypalConfig::METHOD_WPS_EXPRESS,
+            // @phpstan-ignore-next-line - this is a virtual type defined in di.xml
             \Magento\Paypal\Block\PayflowExpress\Shortcut::class => PaypalConfig::METHOD_WPP_PE_EXPRESS,
+            // @phpstan-ignore-next-line - this is a virtual type defined in di.xml
             \Magento\Paypal\Block\Payflow\Bml\Shortcut::class => PaypalConfig::METHOD_WPP_PE_EXPRESS
         ];
         foreach ($blocks as $blockInstanceName => $paymentMethodCode) {

app/code/Magento/Sales/Controller/Adminhtml/Creditmemo/AbstractCreditmemo/PrintAction.php

@@ -73,7 +73,7 @@ public function execute()
                 $fileContent = ['type' => 'string', 'value' => $pdf->render(), 'rm' => true];
 
                 return $this->_fileFactory->create(
-                    \creditmemo::class . $date . '.pdf',
+                    'creditmemo' . $date . '.pdf',
                     $fileContent,
                     DirectoryList::VAR_DIR,
                     'application/pdf'

app/code/Magento/Sales/Test/Unit/Helper/ReorderTest.php

@@ -31,7 +31,7 @@ class ReorderTest extends TestCase
     protected $scopeConfigMock;
 
     /**
-     * @var MockObject|\Magento\Sales\Model\Store
+     * @var MockObject|\Magento\Store\Model\Store
      */
     protected $storeParam;
 
@@ -78,7 +78,7 @@ protected function setUp(): void
             $this->repositoryMock
         );
 
-        $this->storeParam = $this->getMockBuilder(\Magento\Sales\Model\Store::class)
+        $this->storeParam = $this->getMockBuilder(\Magento\Store\Model\Store::class)
             ->disableOriginalConstructor()
             ->getMock();
 

app/code/Magento/SalesRule/Model/ResourceModel/Rule.php

@@ -84,7 +84,7 @@ public function __construct(
         $this->string = $string;
         $this->_resourceCoupon = $resourceCoupon;
         $associatedEntitiesMapInstance = $associatedEntityMapInstance ?: ObjectManager::getInstance()->get(
-            // phpstan:ignore "Class Magento\SalesRule\Model\ResourceModel\Rule\AssociatedEntityMap not found."
+            // @phpstan-ignore-next-line - this is a virtual type defined in di.xml
             \Magento\SalesRule\Model\ResourceModel\Rule\AssociatedEntityMap::class
         );
         $this->_associatedEntitiesMap = $associatedEntitiesMapInstance->getData();

app/code/Magento/SalesRule/Model/ResourceModel/Rule/Collection.php

@@ -463,7 +463,7 @@ private function getAssociatedEntitiesMap()
     {
         if (!$this->_associatedEntitiesMap) {
             $this->_associatedEntitiesMap = \Magento\Framework\App\ObjectManager::getInstance()
-                // phpstan:ignore "Class Magento\SalesRule\Model\ResourceModel\Rule\AssociatedEntityMap not found."
+                // @phpstan-ignore-next-line - this is a virtual type defined in di.xml
                 ->get(\Magento\SalesRule\Model\ResourceModel\Rule\AssociatedEntityMap::class)
                 ->getData();
         }