Merge pull request #9804 from magento-gl/spartans_pr_16052025

[Spartans] BugFix Delivery

Author: glo71317

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/ProductCanonicalUrlTest.php

@@ -1,45 +1,34 @@
 <?php
 /**
- * Copyright © Magento, Inc. All rights reserved.
- * See COPYING.txt for license details.
+ * Copyright 2019 Adobe
+ * All rights reserved.
  */
 declare(strict_types=1);
 
 namespace Magento\GraphQl\Catalog;
 
-use Magento\Catalog\Model\Indexer\Category\Product;
-use Magento\Catalog\Model\Indexer\Product\Category;
-use Magento\CatalogSearch\Model\Indexer\Fulltext as IndexerSearch;
-use Magento\Indexer\Model\Indexer;
-use Magento\TestFramework\Helper\Bootstrap;
-use Magento\TestFramework\ObjectManager;
+use Magento\Indexer\Test\Fixture\Indexer as IndexerFixture;
+use Magento\TestFramework\Fixture\Config;
 use Magento\TestFramework\TestCase\GraphQlAbstract;
+use Magento\Catalog\Test\Fixture\Product as ProductFixture;
+use Magento\TestFramework\Fixture\DataFixture;
+use Magento\TestFramework\Fixture\DataFixtureStorageManager;
 
 /**
  * Test for getting canonical_url for products
  */
 class ProductCanonicalUrlTest extends GraphQlAbstract
 {
-    /** @var ObjectManager */
-    private $objectManager;
-
-    /**
-     * @inheritdoc
-     */
-    protected function setUp(): void
-    {
-        $this->objectManager = Bootstrap::getObjectManager();
-    }
-
-    /**
-     * @magentoApiDataFixture Magento/Catalog/_files/product_simple.php
-     * @magentoConfigFixture default_store catalog/seo/product_canonical_tag 1
-     *
-     */
+    #[
+        Config('catalog/seo/product_canonical_tag', 1),
+        DataFixture(ProductFixture::class, as: 'product'),
+        DataFixture(IndexerFixture::class)
+    ]
     public function testProductWithCanonicalLinksMetaTagSettingsEnabled()
     {
-        $this->reindex();
-        $productSku = 'simple';
+        $product = DataFixtureStorageManager::getStorage()->get('product');
+        $productSku = $product->getSku();
+        $productCanonicalUrl = $product->getUrlKey();
         $query
             = <<<QUERY
 {
@@ -57,19 +46,21 @@ public function testProductWithCanonicalLinksMetaTagSettingsEnabled()
         $this->assertNotEmpty($response['products']['items']);
 
         $this->assertEquals(
-            'simple-product.html',
+            $productCanonicalUrl . '.html',
             $response['products']['items'][0]['canonical_url']
         );
-        $this->assertEquals('simple', $response['products']['items'][0]['sku']);
+        $this->assertEquals($productSku, $response['products']['items'][0]['sku']);
     }
 
-    /**
-     * @magentoApiDataFixture Magento/Catalog/_files/product_simple.php
-     * @magentoConfigFixture default_store catalog/seo/product_canonical_tag 0
-     */
+    #[
+        Config('catalog/seo/product_canonical_tag', 0),
+        DataFixture(ProductFixture::class, as: 'product'),
+        DataFixture(IndexerFixture::class)
+    ]
     public function testProductWithCanonicalLinksMetaTagSettingsDisabled()
     {
-        $productSku = 'simple';
+        $product = DataFixtureStorageManager::getStorage()->get('product');
+        $productSku = $product->getSku();
         $query
             = <<<QUERY
 {
@@ -87,17 +78,6 @@ public function testProductWithCanonicalLinksMetaTagSettingsDisabled()
         $this->assertNull(
             $response['products']['items'][0]['canonical_url']
         );
-        $this->assertEquals('simple', $response['products']['items'][0]['sku']);
-    }
-
-    private function reindex()
-    {
-        $indexer = $this->objectManager->create(Indexer::class);
-        $indexer->load(Product::INDEXER_ID);
-        $indexer->reindexAll();
-        $indexer->load(Category::INDEXER_ID);
-        $indexer->reindexAll();
-        $indexer->load(IndexerSearch::INDEXER_ID);
-        $indexer->reindexAll();
+        $this->assertEquals($productSku, $response['products']['items'][0]['sku']);
     }
 }