Fixing integration tests' warnings

Author: eduard13

app/code/Magento/Analytics/Model/Config/Mapper.php

@@ -52,10 +52,9 @@ public function execute($configData)
                 $providerData['parameters'] = !empty($providerData['parameters'])
                     ? reset($providerData['parameters'])
                     : [];
-                $providerData['parameters'] = array_map(
-                    'reset',
-                    $providerData['parameters']
-                );
+                array_walk($providerData['parameters'], function (&$array) {
+                    $array = reset($array);
+                });
                 $providers[$providerType] = $providerData;
             }
             $files[$fileData['name']] = $fileData;

app/code/Magento/Customer/Model/AccountManagement.php

@@ -1116,7 +1116,7 @@ public function validate(CustomerInterface $customer)
                 // phpcs:ignore Magento2.Functions.DiscouragedFunction
                 call_user_func_array(
                     'array_merge',
-                    $this->getEavValidator()->getMessages()
+                    array_values($this->getEavValidator()->getMessages())
                 )
             );
         }

app/code/Magento/CustomerImportExport/Model/ResourceModel/Import/Address/Storage.php

@@ -98,6 +98,7 @@ private function loadAddresses(array $customerIds): void
         $select->reset(Select::COLUMNS)->columns([$tableId . '.entity_id', $tableId . '.parent_id']);
 
         $pageSize = $this->config->getValue(AbstractEntity::XML_PATH_PAGE_SIZE);
+        $pageSize = !is_null($pageSize) ? (int) $pageSize : null;
         $getChuck = function (int $offset) use ($customerIds, $pageSize) {
             return array_slice($customerIds, $offset, $pageSize);
         };

app/code/Magento/Paypal/Model/Cart.php

@@ -150,7 +150,7 @@ protected function _importItemsFromSalesModel()
         $this->addSubtotal($this->_salesModel->getBaseSubtotal());
         $this->addTax($this->_salesModel->getBaseTaxAmount());
         $this->addShipping($this->_salesModel->getBaseShippingAmount());
-        $this->addDiscount(abs($this->_salesModel->getBaseDiscountAmount()));
+        $this->addDiscount(abs((float) $this->_salesModel->getBaseDiscountAmount()));
     }
 
     /**

app/code/Magento/Sales/Model/ResourceModel/Order/Status.php

@@ -206,7 +206,7 @@ public function checkIsStateLast($state)
             $this->getConnection()->select()
                 ->from(['sss' => $this->stateTable], [])
                 ->where('state = ?', $state)
-                ->columns([new\Zend_Db_Expr('COUNT(1)')])
+                ->columns([new \Zend_Db_Expr('COUNT(1)')])
         ));
     }
 

dev/tests/integration/testsuite/Magento/CatalogImportExport/Model/AbstractProductExportImportTestCase.php

@@ -363,7 +363,7 @@ protected function executeImportReplaceTest(
             /** @var \ReflectionProperty $itemsPerPageProperty */
             $itemsPerPageProperty = $this->objectManager->create(\ReflectionProperty::class, [
                 'class' => \Magento\CatalogImportExport\Model\Export\Product::class,
-                'name' => '_itemsPerPage'
+                'property' => '_itemsPerPage'
             ]);
             $itemsPerPageProperty->setAccessible(true);
             $itemsPerPageProperty->setValue($exportProduct, 1);

dev/tests/integration/testsuite/Magento/Framework/Filter/TemplateTest.php

@@ -56,6 +56,7 @@ public function getThings()
             ['name' => 'Richard', 'age' => 24],
             ['name' => 'Jane', 'age' => 12],
             ['name' => 'Spot', 'age' => 7],
+            ['name' => 'Bill', 'age' => '25']
         ];
     }
 
@@ -105,12 +106,12 @@ public function getFilterForDataProvider()
 
         $expectedResult2 = <<<EXPECTED_RESULT
 <ul>
-    
+
     <li>
         index: 0 sku: ABC123
         name: Product ABC price: 123 quantity: 2
     </li>
-    
+
 </ul>
 EXPECTED_RESULT;
         return [

dev/tests/integration/testsuite/Magento/Framework/View/Utility/Layout.php

@@ -105,7 +105,7 @@ public function getLayoutDependencies()
             'structure' => $objectManager->create(\Magento\Framework\View\Layout\Data\Structure::class, []),
             'messageManager' => $objectManager->get(\Magento\Framework\Message\ManagerInterface::class),
             'themeResolver' => $objectManager->get(\Magento\Framework\View\Design\Theme\ResolverInterface::class),
-            'reader' => $objectManager->get('commonRenderPool'),
+            'readerPool' => $objectManager->get('commonRenderPool'),
             'generatorPool' => $objectManager->get(\Magento\Framework\View\Layout\GeneratorPool::class),
             'cache' => $objectManager->get(\Magento\Framework\App\Cache\Type\Layout::class),
             'readerContextFactory' => $objectManager->get(\Magento\Framework\View\Layout\Reader\ContextFactory::class),

dev/tests/integration/testsuite/Magento/PaypalGraphQl/PaypalExpressAbstractTest.php

@@ -13,10 +13,12 @@
 use Magento\Framework\Exception\LocalizedExceptionFactory;
 use Magento\Framework\HTTP\Adapter\CurlFactory;
 use Magento\Framework\Locale\ResolverInterface;
+use Magento\Framework\Math\Random;
 use Magento\GraphQl\Controller\GraphQl;
 use Magento\GraphQl\Service\GraphQlRequest;
 use Magento\Payment\Model\Method\Logger;
 use Magento\Paypal\Model\Api\Nvp;
+use Magento\Paypal\Model\Api\NvpFactory;
 use Magento\Paypal\Model\Api\PayflowNvp;
 use Magento\Paypal\Model\Api\AbstractApi;
 use Magento\Paypal\Model\Api\ProcessableExceptionFactory;
@@ -150,21 +152,28 @@ protected function disablePaypalPaymentMethods(): void
     private function getNvpMock(string $nvpClass)
     {
         if (empty($this->nvpMock)) {
+            $constructorArgs = [
+                'customerAddress' => $this->objectManager->get(Address::class),
+                'logger' => $this->objectManager->get(LoggerInterface::class),
+                'customLogger' => $this->objectManager->get(Logger::class),
+                'localeResolver' => $this->objectManager->get(ResolverInterface::class),
+                'regionFactory' => $this->objectManager->get(RegionFactory::class),
+                'countryFactory' => $this->objectManager->get(CountryFactory::class),
+                'processableExceptionFactory' => $this->objectManager->get(ProcessableExceptionFactory::class),
+                'frameworkExceptionFactory' => $this->objectManager->get(LocalizedExceptionFactory::class),
+                'curlFactory' => $this->objectManager->get(CurlFactory::class),
+            ];
+
+            if ($nvpClass === PayflowNvp::class) {
+                $constructorArgs += [
+                    'mathRandom' => $this->objectManager->get(Random::class),
+                    'nvpFactory' => $this->objectManager->get(NvpFactory::class)
+                ];
+            }
+
+            $constructorArgs += ['data' => []];
             $this->nvpMock = $this->getMockBuilder($nvpClass)
-                ->setConstructorArgs(
-                    [
-                        'customerAddress' => $this->objectManager->get(Address::class),
-                        'logger' => $this->objectManager->get(LoggerInterface::class),
-                        'customerLogger' => $this->objectManager->get(Logger::class),
-                        'resolverInterface' => $this->objectManager->get(ResolverInterface::class),
-                        'regionFactory' => $this->objectManager->get(RegionFactory::class),
-                        'countryFactory' => $this->objectManager->get(CountryFactory::class),
-                        'processableExceptionFactory' => $this->objectManager->get(ProcessableExceptionFactory::class),
-                        'frameworkExceptionFactory' => $this->objectManager->get(LocalizedExceptionFactory::class),
-                        'curlFactory' => $this->objectManager->get(CurlFactory::class),
-                        'data' => []
-                    ]
-                )
+                ->setConstructorArgs($constructorArgs)
                 ->setMethods(['call'])
                 ->getMock();
         }

lib/internal/Magento/Framework/Filter/DirectiveProcessor/ForDirective.php

@@ -132,7 +132,11 @@ private function getLoopReplacementText(
                 $subText = $loopTextToReplace;
                 foreach ($attributes as $attribute) {
                     $text = $this->variableResolver->resolve($attribute[2], $filter, $templateVariables);
-                    $subText = str_replace($attribute[0], $text, $subText);
+                    $subText = str_replace(
+                        $attribute[0],
+                        is_array($text) ? $text : (string) $text,
+                        $subText
+                    );
                 }
                 $loopText[] = $subText;
             }