Merge pull request #33212 from texboy/eliminate-laminas-crypt

33208 Eliminate laminas/laminas-crypt composer dependency

Author: sivaschenko

composer.json

@@ -37,7 +37,6 @@
         "guzzlehttp/guzzle": "^6.3.3",
         "laminas/laminas-captcha": "^2.10",
         "laminas/laminas-code": "^3.5.1",
-        "laminas/laminas-crypt": "^3.4.0",
         "laminas/laminas-db": "^2.12.0",
         "laminas/laminas-dependency-plugin": "^2.1.0",
         "laminas/laminas-di": "^3.2.0",

composer.lock

@@ -6,11 +6,7 @@
 
 namespace Magento\Framework\Encryption\Helper;
 
-use Laminas\Crypt\Utils;
-
 /**
- * Class implements compareString from Laminas\Crypt
- *
  * @api
  * @since 100.0.2
  */
@@ -19,12 +15,12 @@ class Security
     /**
      * Compare two strings in a secure way that avoids string length guessing based on duration of calculation
      *
-     * @param  string $expected
-     * @param  string $actual
+     * @param string $expected
+     * @param string $actual
      * @return bool
      */
     public static function compareStrings($expected, $actual)
     {
-        return Utils::compareStrings($expected, $actual);
+        return hash_equals((string) $expected, (string) $actual);
     }
 }

lib/internal/Magento/Framework/Encryption/Helper/Security.php

@@ -26,7 +26,6 @@
         "composer/composer": "^1.9 || ^2.0",
         "guzzlehttp/guzzle": "^6.3.3",
         "laminas/laminas-code": "^3.5.1",
-        "laminas/laminas-crypt": "^3.4.0",
         "laminas/laminas-http": "^2.6.0",
         "laminas/laminas-mail": "^2.9.0",
         "laminas/laminas-mime": "^2.8.0",