🔃 [Magento Community Engineering] Community Contributions - 2.3-develop expedited

Accepted Community Pull Requests:
 - #15383: issue fixed #8258 - assign indices for all array inputs so that validation works properly (by @jayankaghosh)
 - #18075: Feature/issue 13561 2.3 (by @bnymn)


Fixed GitHub Issues:
 - #8258: M2.1.3 : Form validation with identical field names does not work as expected. (reported by @kanduvisla) has been fixed in #15383 by @jayankaghosh in 2.3-develop branch
   Related commits:
     1. 113440f
     2. 874d770
     3. 84355a3
     4. d5c41b6
     5. 156ac16
     6. 65a2c17
     7. 97c03f5
     8. 224f737
     9. 908100b
     10. 38b9709
     11. 388d31d
     12. ee288c1
     13. eadcff2

 - #13561: Magento 2 and SSL connection to MySQL (reported by @craigcarnell) has been fixed in #18075 by @bnymn in 2.3-develop branch
   Related commits:
     1. 41e1793
     2. 3b67548
     3. def50d5
     4. 7c7cc9b
     5. ddad680
     6. fa659d2
     7. 968a59c
     8. 5cfad03
     9. 7c7760b
     10. 6f19bf0
     11. d97af67
     12. 6cd243d
     13. 7b13705
     14. 93931d2
     15. db60f71
     16. d27e9a4
     17. f06a4b7
     18. 309e906
     19. f04a5a9
     20. f7ee0cc
     21. c4cc952
     22. 26980d8
     23. 610dcff

Author: magento-engcom-team

dev/tests/functional/tests/app/Magento/CheckoutAgreements/Test/Block/Adminhtml/Block/Agreement/Edit/AgreementsForm.xml

@@ -18,7 +18,7 @@
             <input>select</input>
         </mode>
         <stores>
-            <selector>[name="stores[]"]</selector>
+            <selector>[name="stores[0]"]</selector>
             <input>multiselectgrouplist</input>
         </stores>
         <checkbox_text />

dev/tests/functional/tests/app/Magento/Customer/Test/Block/Form/CustomerForm.php

@@ -29,7 +29,7 @@ class CustomerForm extends Form
      *
      * @var string
      */
-    protected $customerAttribute = "[name='%s[]']";
+    protected $customerAttribute = "[orig-name='%s[]']";
 
     /**
      * Validation text message for a field.

dev/tests/functional/tests/app/Magento/Newsletter/Test/Block/Adminhtml/Queue/Edit/QueueForm.xml

@@ -11,7 +11,7 @@
             <selector>input[name='start_at']</selector>
         </queue_start_at>
         <stores>
-            <selector>select[name="stores[]"]</selector>
+            <selector>select[name="stores[0]"]</selector>
             <input>multiselectgrouplist</input>
         </stores>
         <newsletter_subject>

dev/tests/functional/tests/app/Magento/Reports/Test/Block/Adminhtml/Sales/Coupons/Filter.xml

@@ -29,7 +29,7 @@
             <input>select</input>
         </price_rule_type>
         <order_statuses>
-            <selector>[name="order_statuses[]"]</selector>
+            <selector>[name="order_statuses[0]"]</selector>
             <input>multiselect</input>
         </order_statuses>
         <rules_list>

dev/tests/functional/tests/app/Magento/Reports/Test/Block/Adminhtml/Sales/TaxRule/Filter.xml

@@ -23,7 +23,7 @@
             <input>select</input>
         </show_order_statuses>
         <order_statuses>
-            <selector>[name="order_statuses[]"]</selector>
+            <selector>[name="order_statuses[0]"]</selector>
             <input>multiselect</input>
         </order_statuses>
         <show_empty_rows>

dev/tests/functional/tests/app/Magento/Review/Test/Block/Adminhtml/Rating/Edit/RatingForm.xml

@@ -12,7 +12,7 @@
         <strategy>css selector</strategy>
         <fields>
             <stores>
-                <selector>[name="stores[]"]</selector>
+                <selector>[name="stores[0]"]</selector>
                 <input>multiselectgrouplist</input>
             </stores>
             <is_active>

dev/tests/functional/tests/app/Magento/Sales/Test/Block/Adminhtml/Report/Filter/Form.xml

@@ -26,7 +26,7 @@
             <input>select</input>
         </show_order_statuses>
         <order_statuses>
-            <selector>[name="order_statuses[]"]</selector>
+            <selector>[name="order_statuses[0]"]</selector>
             <input>multiselect</input>
         </order_statuses>
         <show_actual_columns>

dev/tests/functional/tests/app/Magento/Widget/Test/Block/Adminhtml/Widget/Instance/Edit/Tab/ParametersType/RecentlyComparedProducts.xml

@@ -12,13 +12,13 @@
         </page_size>
         <show_attributes>
             <selector>
-                .control [name="parameters[show_attributes][]"]
+                .control [name="parameters[show_attributes][1]"]
             </selector>
             <input>multiselect</input>
         </show_attributes>
         <show_buttons>
             <selector>
-                .control [name="parameters[show_buttons][]"]
+                .control [name="parameters[show_buttons][2]"]
             </selector>
             <input>multiselect</input>
         </show_buttons>

dev/tests/functional/tests/app/Magento/Widget/Test/Block/Adminhtml/Widget/Instance/Edit/Tab/ParametersType/RecentlyViewedProducts.xml

@@ -12,13 +12,13 @@
         </page_size>
         <show_attributes>
             <selector>
-                .control [name="parameters[show_attributes][]"]
+                .control [name="parameters[show_attributes][1]"]
             </selector>
             <input>multiselect</input>
         </show_attributes>
         <show_buttons>
             <selector>
-                .control [name="parameters[show_buttons][]"]
+                .control [name="parameters[show_buttons][2]"]
             </selector>
             <input>multiselect</input>
         </show_buttons>

dev/tests/functional/tests/app/Magento/Widget/Test/Block/Adminhtml/WidgetForm.xml

@@ -32,13 +32,13 @@
         <page_size />
         <show_attributes>
             <selector>
-                .control [name="parameters[show_attributes][]"]
+                .control [name="parameters[show_attributes][1]"]
             </selector>
             <input>multiselect</input>
         </show_attributes>
         <show_buttons>
             <selector>
-                .control [name="parameters[show_buttons][]"]
+                .control [name="parameters[show_buttons][2]"]
             </selector>
             <input>multiselect</input>
         </show_buttons>