ACP2E-2673: Price partial indexing performance

- reverted to delete statement for empty tables because of Galera cluster locks

Author: aplapana

app/code/Magento/Catalog/Model/Indexer/Product/Price/AbstractAction.php

@@ -408,14 +408,11 @@ function ($type) use ($productsTypes) {
                 foreach ($this->dimensionCollectionFactory->create() as $dimensions) {
                     $this->tableMaintainer->createMainTmpTable($dimensions);
                     $temporaryTable = $this->tableMaintainer->getMainTmpTable($dimensions);
+                    $this->_emptyTable($temporaryTable);
                     $indexer->executeByDimensions($dimensions, \SplFixedArray::fromArray($entityIds, false));
                     $mainTable = $this->tableMaintainer->getMainTableByDimensions($dimensions);
                     $this->_insertFromTable($temporaryTable, $mainTable);
                     $this->deleteOutdatedData($entityIds, $temporaryTable, $mainTable);
-                    // phpcs:ignore Magento2.SQL.RawQuery.FoundRawSql
-                    $this->getConnection()->query(
-                        'TRUNCATE TABLE ' . $this->getConnection()->quoteIdentifier($temporaryTable)
-                    );
                 }
             } else {
                 // handle 3d-party indexers for backward compatibility

app/code/Magento/Catalog/Test/Unit/Model/Indexer/Product/Price/Action/RowsTest.php

@@ -144,7 +144,6 @@ public function testBatchProcessing()
         $adapter = $this->createMock(AdapterInterface::class);
         $adapter->method('select')->willReturn($select);
         $adapter->method('describeTable')->willReturn([]);
-        $adapter->expects($this->exactly(4))->method('dropTable');
         $this->defaultIndexerResource->method('getConnection')->willReturn($adapter);
         $adapter->method('fetchAll')->with($select)->willReturn([]);
 
@@ -194,21 +193,7 @@ public function testBatchProcessing()
             ->method('getPrimaryKeyName')
             ->willReturn('entity_id');
 
-        $actionRows = new Rows(
-            $this->config,
-            $this->storeManager,
-            $this->currencyFactory,
-            $this->localeDate,
-            $this->dateTime,
-            $this->catalogProductType,
-            $this->indexerPriceFactory,
-            $this->defaultIndexerResource,
-            $this->tierPriceIndexResource,
-            $this->dimensionCollectionFactory,
-            $this->tableMaintainer,
-            2
-        );
-        $actionRows->execute($ids);
+        $this->actionRows->execute($ids);
     }
 
     public function testDeletedProductsBatchProcessing()