AC-746: Malformed request body or parameters cause Internal Server Error

wip44850 · wip44850 · commit 4f2cbfa18d03 · 2025-07-07T22:47:19.000+05:30
diff --git a/dev/tests/api-functional/testsuite/Magento/Framework/Webapi/ApiErrorProcessorTest.php b/dev/tests/api-functional/testsuite/Magento/Framework/Webapi/ApiErrorProcessorTest.php
@@ -69,23 +69,6 @@ public function testMalformedRequestParams(array $requestData, string $endpoint,
     public static function malformedRequestParamsDataProvider()
     {
         return [
-            'empty_filter_groups_field' => [
-                'requestData' => [
-                    'searchCriteria' => [
-                        'filterGroups' => [
-                            [
-                                'filters' => [
-                                    [
-                                        'value' => 'string'
-                                    ]
-                                ]
-                            ]
-                        ]
-                    ]
-                ],
-                'endpoint' => 'eav/attribute-sets/list',
-                'expectedExceptionCode' => 400,
-            ],
             'empty_filter_groups_value' => [
                 'requestData' => [
                     'searchCriteria' => [
@@ -103,23 +86,6 @@ public static function malformedRequestParamsDataProvider()
                 'endpoint' => 'coupons/search',
                 'expectedExceptionCode' => 400,
             ],
-            'empty_filter_groups_field2' => [
-                'requestData' => [
-                    'searchCriteria' => [
-                        'filterGroups' => [
-                            [
-                                'filters' => [
-                                    [
-                                        'value' => 'string'
-                                    ]
-                                ]
-                            ]
-                        ]
-                    ]
-                ],
-                'endpoint' => 'cmsBlock/search',
-                'expectedExceptionCode' => 400,
-            ],
             'empty_filter_groups_value2' => [
                 'requestData' => [
                     'searchCriteria' => [
diff --git a/lib/internal/Magento/Framework/Webapi/ErrorProcessor.php b/lib/internal/Magento/Framework/Webapi/ErrorProcessor.php
@@ -179,7 +179,6 @@ private function getClientErrorHttpCode(\Exception $exception)
     {
         // Check if this is a client error based on the exception type
         if ($exception instanceof \Zend_Db_Exception
-            || $exception instanceof \Exception
             || $exception instanceof \Zend_Db_Adapter_Exception
             || $exception instanceof \Zend_Db_Statement_Exception
             || $exception instanceof \PDOException

Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,6 @@ private function getClientErrorHttpCode(\Exception $exception)`
`179`	`179`	`{`
`180`	`180`	`// Check if this is a client error based on the exception type`
`181`	`181`	`if ($exception instanceof \Zend_Db_Exception`
`182`		`- \|\| $exception instanceof \Exception`
`183`	`182`	`\|\| $exception instanceof \Zend_Db_Adapter_Exception`
`184`	`183`	`\|\| $exception instanceof \Zend_Db_Statement_Exception`
`185`	`184`	`\|\| $exception instanceof \PDOException`