AC-9460: Stored XSS fix via PayPal authentication certificate

faraz-gl · faraz-gl · commit 4de2190ad4c1 · 2023-09-19T12:37:17.000+05:30
* BIC fix
diff --git a/app/code/Magento/Config/Block/System/Config/Form/Field/File.php b/app/code/Magento/Config/Block/System/Config/Form/Field/File.php
@@ -19,11 +19,6 @@
 
 class File extends \Magento\Framework\Data\Form\Element\File
 {
-    /**
-     * @var Escaper
-     */
-    private Escaper $escaper;
-
     /**
      * @param Factory $factoryElement
      * @param CollectionFactory $factoryCollection
@@ -45,7 +40,7 @@ public function __construct(
      *
      * @return string
      */
-    public function getElementHtml(): string
+    public function getElementHtml()
     {
         $html = parent::getElementHtml();
         $html .= $this->_getDeleteCheckbox();
@@ -57,7 +52,7 @@ public function getElementHtml(): string
      *
      * @return string
      */
-    protected function _getDeleteCheckbox(): string
+    protected function _getDeleteCheckbox()
     {
         $html = '';
         if ((string)$this->getValue()) {

Original file line number	Diff line number	Diff line change
`@@ -19,11 +19,6 @@`
`19`	`19`
`20`	`20`	`class File extends \Magento\Framework\Data\Form\Element\File`
`21`	`21`	`{`
`22`		`- /**`
`23`		`- * @var Escaper`
`24`		`- */`
`25`		`- private Escaper $escaper;`
`26`		`-`
`27`	`22`	`/**`
`28`	`23`	`* @param Factory $factoryElement`
`29`	`24`	`* @param CollectionFactory $factoryCollection`
`@@ -45,7 +40,7 @@ public function __construct(`
`45`	`40`	`*`
`46`	`41`	`* @return string`
`47`	`42`	`*/`
`48`		`- public function getElementHtml(): string`
	`43`	`+ public function getElementHtml()`
`49`	`44`	`{`
`50`	`45`	`$html = parent::getElementHtml();`
`51`	`46`	`$html .= $this->_getDeleteCheckbox();`
`@@ -57,7 +52,7 @@ public function getElementHtml(): string`
`57`	`52`	`*`
`58`	`53`	`* @return string`
`59`	`54`	`*/`
`60`		`- protected function _getDeleteCheckbox(): string`
	`55`	`+ protected function _getDeleteCheckbox()`
`61`	`56`	`{`
`62`	`57`	`$html = '';`
`63`	`58`	`if ((string)$this->getValue()) {`