Skip to content

Commit 4dbff82

Browse files
committed
AC-14464: GraphQL addWishlistItemsToCart Fails to Update Quantity for Existing Cart Items When One Wishlist Item Is Invalid (Magento 2.4.7-p3
) Fix static test failure
1 parent 43f5935 commit 4dbff82

File tree

2 files changed

+6
-18
lines changed

2 files changed

+6
-18
lines changed

app/code/Magento/WishlistGraphQl/Model/Resolver/Wishlist/AddToCart.php

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -21,24 +21,19 @@
2121
use Magento\Quote\Model\Cart\Data\Error;
2222
use Magento\WishlistGraphQl\Mapper\WishlistDataMapper;
2323
use Magento\WishlistGraphQl\Model\CartItems\CartItemsRequestBuilder;
24-
use Magento\Wishlist\Model\LocaleQuantityProcessor;
2524
use Magento\Wishlist\Model\ResourceModel\Item\Collection as WishlistItemsCollection;
2625
use Magento\Wishlist\Model\ResourceModel\Wishlist as WishlistResourceModel;
2726
use Magento\Wishlist\Model\Wishlist;
2827
use Magento\Wishlist\Model\WishlistFactory;
29-
use Magento\Wishlist\Model\Wishlist\AddProductsToWishlist as AddProductsToWishlistModel;
3028
use Magento\Wishlist\Model\Wishlist\Config as WishlistConfig;
3129

3230
/**
3331
* Adding products to wishlist resolver
32+
*
33+
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
3434
*/
3535
class AddToCart implements ResolverInterface
3636
{
37-
/**
38-
* @var AddProductsToWishlistModel
39-
*/
40-
private $addProductsToWishlist;
41-
4237
/**
4338
* @var WishlistDataMapper
4439
*/
@@ -59,11 +54,6 @@ class AddToCart implements ResolverInterface
5954
*/
6055
private $wishlistFactory;
6156

62-
/**
63-
* @var LocaleQuantityProcessor
64-
*/
65-
private $quantityProcessor;
66-
6757
/**
6858
* @var CreateEmptyCartForCustomer
6959
*/
@@ -93,9 +83,7 @@ class AddToCart implements ResolverInterface
9383
* @param WishlistResourceModel $wishlistResource
9484
* @param WishlistFactory $wishlistFactory
9585
* @param WishlistConfig $wishlistConfig
96-
* @param AddProductsToWishlistModel $addProductsToWishlist
9786
* @param WishlistDataMapper $wishlistDataMapper
98-
* @param LocaleQuantityProcessor $quantityProcessor
9987
* @param CreateEmptyCartForCustomer $createEmptyCartForCustomer
10088
* @param AddProductsToCartService $addProductsToCart
10189
* @param CartItemsRequestBuilder $cartItemsRequestBuilder
@@ -106,9 +94,7 @@ public function __construct(
10694
WishlistResourceModel $wishlistResource,
10795
WishlistFactory $wishlistFactory,
10896
WishlistConfig $wishlistConfig,
109-
AddProductsToWishlistModel $addProductsToWishlist,
11097
WishlistDataMapper $wishlistDataMapper,
111-
LocaleQuantityProcessor $quantityProcessor,
11298
CreateEmptyCartForCustomer $createEmptyCartForCustomer,
11399
AddProductsToCartService $addProductsToCart,
114100
CartItemsRequestBuilder $cartItemsRequestBuilder,
@@ -118,9 +104,7 @@ public function __construct(
118104
$this->wishlistResource = $wishlistResource;
119105
$this->wishlistFactory = $wishlistFactory;
120106
$this->wishlistConfig = $wishlistConfig;
121-
$this->addProductsToWishlist = $addProductsToWishlist;
122107
$this->wishlistDataMapper = $wishlistDataMapper;
123-
$this->quantityProcessor = $quantityProcessor;
124108
$this->createEmptyCartForCustomer = $createEmptyCartForCustomer;
125109
$this->addProductsToCartService = $addProductsToCart;
126110
$this->cartItemsRequestBuilder = $cartItemsRequestBuilder;
@@ -130,6 +114,8 @@ public function __construct(
130114

131115
/**
132116
* @inheritdoc
117+
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
118+
* @SuppressWarnings(PHPMD.NPathComplexity)
133119
*/
134120
public function resolve(
135121
Field $field,

app/code/Magento/WishlistGraphQl/Test/Unit/Model/Resolver/Wishlist/AddToCartTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -462,6 +462,8 @@ public function testResolveSuccessfulAddToCartWithItemRemoval(): void
462462

463463
/**
464464
* Test resolve with errors when adding to cart
465+
*
466+
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
465467
*/
466468
public function testResolveWithAddToCartErrors(): void
467469
{

0 commit comments

Comments
 (0)