CABPI-458: [Bug] Magento issue with DI compilation on 2.4.5-alpha1

 -- fix static failure

Author: andimov

app/code/Magento/CatalogRule/Controller/Adminhtml/Promo/Catalog/NewConditionHtml.php

@@ -7,6 +7,7 @@
 namespace Magento\CatalogRule\Controller\Adminhtml\Promo\Catalog;
 
 use Magento\CatalogRule\Controller\Adminhtml\Promo\Catalog as CatalogAction;
+use Magento\CatalogRule\Model\Rule;
 use Magento\Framework\App\Action\HttpGetActionInterface;
 use Magento\Framework\App\Action\HttpPostActionInterface as HttpPostActionInterface;
 use Magento\Rule\Model\Condition\AbstractCondition;
@@ -21,34 +22,36 @@ class NewConditionHtml extends CatalogAction implements HttpPostActionInterface,
      */
     public function execute()
     {
-        $id = $this->getRequest()->getParam('id');
-        $formName = $this->getRequest()->getParam('form_namespace');
-        $typeArr = explode('|', str_replace('-', '/', $this->getRequest()->getParam('type', '')));
-        $type = $typeArr[0];
+        $objectId = $this->getRequest()->getParam('id');
+        $formNamespace = $this->getRequest()->getParam('form_namespace');
+        $types = explode(
+            '|',
+            str_replace('-', '/', $this->getRequest()->getParam('type', ''))
+        );
+        $objectType = $types[0];
+        $reponseBody = '';
 
-        if (class_exists($type) && !in_array(ConditionInterface::class, class_implements($type))) {
-            $html = '';
-            $this->getResponse()->setBody($html);
+        if (class_exists($objectType) && !in_array(ConditionInterface::class, class_implements($objectType))) {
+            $this->getResponse()->setBody($reponseBody);
             return;
         }
 
-        $model = $this->_objectManager->create($type)
-            ->setId($id)
-            ->setType($type)
-            ->setRule($this->_objectManager->create(\Magento\CatalogRule\Model\Rule::class))
+        $conditionModel = $this->_objectManager->create($objectType)
+            ->setId($objectId)
+            ->setType($objectType)
+            ->setRule($this->_objectManager->create(Rule::class))
             ->setPrefix('conditions');
 
-        if (!empty($typeArr[1])) {
-            $model->setAttribute($typeArr[1]);
+        if (!empty($types[1])) {
+            $conditionModel->setAttribute($types[1]);
         }
 
-        if ($model instanceof AbstractCondition) {
-            $model->setJsFormObject($this->getRequest()->getParam('form'));
-            $model->setFormName($formName);
-            $html = $model->asHtmlRecursive();
-        } else {
-            $html = '';
+        if ($conditionModel instanceof AbstractCondition) {
+            $conditionModel->setJsFormObject($this->getRequest()->getParam('form'));
+            $conditionModel->setFormName($formNamespace);
+            $reponseBody = $conditionModel->asHtmlRecursive();
         }
-        $this->getResponse()->setBody($html);
+
+        $this->getResponse()->setBody($reponseBody);
     }
 }