ACP2E-2622: Unable to save changes to phone number in existing order details

     - Fixed CR comments

Author: lakshmana49

app/code/Magento/Sales/Model/ResourceModel/Order/Address.php

@@ -5,6 +5,7 @@
  */
 namespace Magento\Sales\Model\ResourceModel\Order;
 
+use Magento\Framework\Model\AbstractModel;
 use Magento\Sales\Model\ResourceModel\EntityAbstract as SalesResource;
 use Magento\Sales\Model\Spi\OrderAddressResourceInterface;
 use Magento\Framework\Model\ResourceModel\Db\VersionControl\Snapshot;
@@ -124,12 +125,9 @@ protected function _beforeSave(\Magento\Framework\Model\AbstractModel $object)
     }
 
     /**
-     * Check is current order address entity has changes, by comparing current object state with stored snapshot
-     *
-     * @param \Magento\Framework\DataObject $entity
-     * @return bool
+     * @inheritdoc
      */
-    protected function isModified(\Magento\Framework\Model\AbstractModel $entity)
+    protected function isModified(AbstractModel $entity): bool
     {
         if (!$entity->getId()) {
             return true;

dev/tests/integration/testsuite/Magento/Sales/Model/ResourceModel/Order/AddressTest.php

@@ -79,7 +79,6 @@ protected function setUp(): void
      * @throws LocalizedException
      */
     #[
-        DbIsolation(false),
         DataFixture(ProductFixture::class, as: 'product'),
         DataFixture(Customer::class, as: 'customer'),
         DataFixture(CustomerCart::class, ['customer_id' => '$customer.id$'], as: 'quote'),

lib/internal/Magento/Framework/Model/ResourceModel/Db/VersionControl/Snapshot.php

@@ -57,7 +57,7 @@ public function registerSnapshot(\Magento\Framework\DataObject $entity)
      * @param DataObject $entity
      * @return array
      */
-    public function getSnapshotData(\Magento\Framework\DataObject $entity)
+    public function getSnapshotData(DataObject $entity): array
     {
         $entityClass = get_class($entity);
         $entityId = $entity->getId();