add test cases for middlename

Author: karyna-t

app/code/Magento/Sales/Model/Order.php

@@ -2039,17 +2039,17 @@ public function getCustomerName()
 
         $customerName = '';
         $prefix = $this->getCustomerPrefix();
-        if (($prefix !== null) && $this->isVisibleCustomerPrefix() && strlen($prefix)) {
+        if ($prefix !== null && $this->isVisibleCustomerPrefix() && strlen($prefix)) {
             $customerName .= $prefix . ' ';
         }
         $customerName .= $this->getCustomerFirstname();
         $middlename = $this->getCustomerMiddlename();
-        if (($middlename !== null) && $this->isVisibleCustomerMiddlename() && strlen($middlename)) {
+        if ($middlename !== null && $this->isVisibleCustomerMiddlename() && strlen($middlename)) {
             $customerName .= ' ' . $middlename;
         }
         $customerName .= ' ' . $this->getCustomerLastname();
         $suffix = $this->getCustomerSuffix();
-        if (($suffix !== null) && $this->isVisibleCustomerSuffix() && strlen($suffix)) {
+        if ($suffix !== null && $this->isVisibleCustomerSuffix() && strlen($suffix)) {
             $customerName .= ' ' . $suffix;
         }
 

app/code/Magento/Sales/Test/Unit/Model/OrderTest.php

@@ -401,8 +401,12 @@ public function testCanInvoice()
     public function testGetCustomerName(array $expectedData)
     {
         $this->order->setCustomerFirstname($expectedData['first_name']);
+        $this->order->setCustomerMiddlename($expectedData['middle_name']);
         $this->order->setCustomerSuffix($expectedData['customer_suffix']);
         $this->order->setCustomerPrefix($expectedData['customer_prefix']);
+        $this->scopeConfigMock->expects($this->exactly($expectedData['invocation']))
+            ->method('isSetFlag')
+            ->willReturn(true);
         $this->assertEquals($expectedData['expected_name'], $this->order->getCustomerName());
     }
 
@@ -416,6 +420,8 @@ public function customerNameProvider()
                 [
                     [
                         'first_name' => null,
+                        'invocation' => 0,
+                        'middle_name' => null,
                         'expected_name' => 'Guest',
                         'customer_suffix' => 'smith',
                         'customer_prefix' => 'mr.'
@@ -424,10 +430,22 @@ public function customerNameProvider()
                 [
                     [
                         'first_name' => 'Smith',
+                        'invocation' => 0,
+                        'middle_name' => null,
                         'expected_name' => 'mr. Smith  Carl',
                         'customer_suffix' => 'Carl',
                         'customer_prefix' => 'mr.'
                     ]
+                ],
+                [
+                    [
+                        'first_name' => 'John',
+                        'invocation' => 1,
+                        'middle_name' => 'Middle',
+                        'expected_name' => 'mr. John Middle  Carl',
+                        'customer_suffix' => 'Carl',
+                        'customer_prefix' => 'mr.'
+                    ]
                 ]
             ];
     }