Skip to content

Commit 49ef17c

Browse files
committed
ACP2E-4128: [CLOUD] Getting 404 for JS file on checkout page on first attempt after implementing sri patch
1 parent be8dfb4 commit 49ef17c

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

app/code/Magento/Csp/Plugin/GenerateAssetIntegrity.php

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,11 @@ public function afterCreateRequireJsMixinsAsset(
105105
): File {
106106
if (PHP_SAPI == 'cli') {
107107
if (in_array($result->getContentType(), self::CONTENT_TYPES)) {
108-
$content = $result->getContent();
108+
try {
109+
$content = $result->getContent();
110+
} catch (\Exception $e) {
111+
$content = null;
112+
}
109113
$path = $result->getPath();
110114

111115
if ($content !== null) {
@@ -141,7 +145,11 @@ public function afterCreateStaticJsAsset(
141145
): File {
142146
if (PHP_SAPI == 'cli') {
143147
if (in_array($result->getContentType(), self::CONTENT_TYPES)) {
144-
$content = $result->getContent();
148+
try {
149+
$content = $result->getContent();
150+
} catch (\Exception $e) {
151+
$content = null;
152+
}
145153
$path = $result->getPath();
146154

147155
if ($content !== null) {

app/code/Magento/Deploy/Service/DeployRequireJsConfig.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,9 +120,9 @@ public function deploy($areaCode, $themePath, $localeCode)
120120

121121
if ($this->bundleConfig->isBundlingJsFiles()) {
122122
$fileManager->createStaticJsAsset();
123+
$fileManager->createRequireJsMixinsAsset();
123124
}
124125
$fileManager->createRequireJsConfigAsset();
125-
$fileManager->createRequireJsMixinsAsset();
126126
$fileManager->createMinResolverAsset();
127127

128128
return true;

app/code/Magento/Deploy/Test/Unit/Service/DeployRequireJsConfigTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,12 +289,13 @@ private function setupFileManagerMocks(bool $bundlingEnabled): void
289289
{
290290
if ($bundlingEnabled) {
291291
$this->fileManager->expects($this->once())->method('createStaticJsAsset');
292+
$this->fileManager->expects($this->once())->method('createRequireJsMixinsAsset');
292293
} else {
293294
$this->fileManager->expects($this->never())->method('createStaticJsAsset');
295+
$this->fileManager->expects($this->never())->method('createRequireJsMixinsAsset');
294296
}
295297

296298
$this->fileManager->expects($this->once())->method('createRequireJsConfigAsset');
297-
$this->fileManager->expects($this->once())->method('createRequireJsMixinsAsset');
298299
$this->fileManager->expects($this->once())->method('createMinResolverAsset');
299300
}
300301
}

0 commit comments

Comments
 (0)