ACP2E-3897: [Mainline] Wrong results in products graphQL query

Author: veloraven

app/code/Magento/CatalogGraphQl/DataProvider/Product/SearchCriteriaBuilder.php

@@ -38,7 +38,7 @@ class SearchCriteriaBuilder
      * @param RequestDataBuilder $localData
      * @param SearchCriteriaResolverFactory $criteriaResolverFactory
      * @param ArgumentApplierPool $argumentApplierPool
-     * @param array $partial_search_analyzers
+     * @param array $partialSearchAnalyzers
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
@@ -52,7 +52,7 @@ public function __construct(
         private readonly RequestDataBuilder $localData,
         private readonly SearchCriteriaResolverFactory $criteriaResolverFactory,
         private readonly ArgumentApplierPool $argumentApplierPool,
-        private readonly array $partial_search_analyzers = []
+        private readonly array $partialSearchAnalyzers = []
     ) {
     }
 
@@ -119,9 +119,9 @@ private function updateMatchTypeRequestConfig(string $requestName, array $partia
             foreach ($query['match'] ?? [] as $index => $matchItem) {
                 if (in_array($matchItem['field'] ?? null, $partialMatchFilters, true)) {
                     $data['queries'][$queryName]['match'][$index]['matchCondition'] = 'match_phrase_prefix';
-                    if (array_key_exists($matchItem['field'], $this->partial_search_analyzers)) {
+                    if (array_key_exists($matchItem['field'], $this->partialSearchAnalyzers)) {
                         $data['queries'][$queryName]['match'][$index]['analyzer']
-                            = $this->partial_search_analyzers[$matchItem['field']];
+                            = $this->partialSearchAnalyzers[$matchItem['field']];
                     }
                 }
             }

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/ProductSearchTest.php

@@ -205,34 +205,26 @@ public function sortByPriceAndNameDataProvider(): array
     }
 
     /**
-     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      * @dataProvider filterByNameWithMatchTypeSpecifiedDataProvider
      */
     #[
         DataFixture(ProductFixture::class, ['price' => 10, 'name' => 'Cronus Yoga Pant'], 'prod1'),
         DataFixture(ProductFixture::class, ['price' => 10, 'name' => 'Lucia Cross-Fit Bra'], 'prod2'),
         DataFixture(ProductFixture::class, ['price' => 20, 'name' => 'Crown Summit Backpack'], 'prod3'),
     ]
-    public function testFilterByNameWithMatchTypeSpecified($matchType, $expectedOrder, $expectedTotalCount): void
+    public function testFilterByNameWithMatchTypeSpecified($matchType, $expectedReturns, $expectedTotalCount): void
     {
         $expectedNames = [];
-        foreach ($expectedOrder as $productName) {
+        foreach ($expectedReturns as $productName) {
             $expectedNames[] = $this->fixture->get($productName)->getName();
         }
         $query = <<<'QUERY'
 query GetProductsQuery(
-    $search: String,
     $searchWord: String,
     $matchType: FilterMatchTypeEnum
-    $pageSize: Int,
-    $currentPage: Int
 ) {
     products(
-        search: $search,
         filter: {name: {match: $searchWord, match_type: $matchType} },
-        pageSize: $pageSize,
-        currentPage: $currentPage,
-        sort: {name: ASC}
     ) {
         total_count
         page_info{total_pages}
@@ -246,11 +238,8 @@ public function testFilterByNameWithMatchTypeSpecified($matchType, $expectedOrde
 }
 QUERY;
         $variables = [
-            'search' => null,
             'searchWord' => 'Cros',
             'matchType' => $matchType,
-            'pageSize' => 24,
-            'currentPage' => 1
         ];
 
         $response = $this->graphQlQuery($query, $variables);