ACP2E-3709: [Cloud] Changing table column type from Int to Decimal using db_schema.xml file In Magento 2 Results In Errors

Author: soklymeach

lib/internal/Magento/Framework/Config/Reader/Filesystem.php

@@ -1,7 +1,7 @@
 <?php
 /**
- *  Copyright 2014 Adobe
- *  All Rights Reserved.
+ * Copyright 2014 Adobe
+ * All Rights Reserved.
  */
 
 namespace Magento\Framework\Config\Reader;
@@ -84,7 +84,7 @@ class Filesystem implements \Magento\Framework\Config\ReaderInterface
     /**
      * Name of an attribute that stands for data type of node values
      */
-    public const TYPE_ATTRIBUTE = 'xsi:type';
+    private const TYPE_ATTRIBUTE = 'xsi:type';
 
     /**
      * Constructor

lib/internal/Magento/Framework/Config/Test/Unit/Reader/FilesystemTest.php

@@ -1,7 +1,7 @@
 <?php
 /**
- * Copyright © Magento, Inc. All rights reserved.
- * See COPYING.txt for license details.
+ * Copyright 2014 Adobe
+ * All Rights Reserved.
  */
 declare(strict_types=1);
 
@@ -15,6 +15,7 @@
 use Magento\Framework\Config\ValidationStateInterface;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
+use Magento\Framework\Config\Dom;
 
 /**
  * Test for
@@ -53,6 +54,11 @@ class FilesystemTest extends TestCase
      */
     protected $_file;
 
+    /**
+     * @var Filesystem
+     */
+    private $filesystem;
+
     protected function setUp(): void
     {
         if (!function_exists('libxml_set_external_entity_loader')) {
@@ -64,6 +70,16 @@ protected function setUp(): void
         $this->_schemaLocatorMock = $this->getMockForAbstractClass(SchemaLocatorInterface::class);
         $this->_validationStateMock = $this->getMockForAbstractClass(ValidationStateInterface::class);
         $this->urnResolver = new UrnResolver();
+        $this->filesystem = new Filesystem(
+            $this->_fileResolverMock,
+            $this->_converterMock,
+            $this->_schemaLocatorMock,
+            $this->_validationStateMock,
+            'test.xml',
+            ['/test/node' => 'id'],
+            Dom::class,
+            'global'
+        );
     }
 
     public function testRead()
@@ -170,4 +186,32 @@ public function testReadException()
         );
         $model->read();
     }
+
+    public function testCreateConfigMergerSuccess()
+    {
+        $initialContents = '<?xml version="1.0"?><config><test id="1"/></config>';
+        $reflection = new \ReflectionClass($this->filesystem);
+        $method = $reflection->getMethod('_createConfigMerger');
+        $result = $method->invokeArgs(
+            $this->filesystem,
+            [Dom::class, $initialContents]
+        );
+        $this->assertInstanceOf(\Magento\Framework\Config\Dom::class, $result);
+        $domReflection = new \ReflectionClass($result);
+        $typeAttributeProperty = $domReflection->getProperty('typeAttributeName');
+        $this->assertEquals('xsi:type', $typeAttributeProperty->getValue($result));
+    }
+
+    public function testCreateConfigMergerThrowsException()
+    {
+        $initialContents = '<?xml version="1.0"?><config><test id="1"/></config>';
+        $wrongClass = \stdClass::class;
+        $reflection = new \ReflectionClass($this->filesystem);
+        $method = $reflection->getMethod('_createConfigMerger');
+        $this->expectException(\UnexpectedValueException::class);
+        $this->expectExceptionMessage(
+            "Instance of the DOM config merger is expected, got {$wrongClass} instead."
+        );
+        $method->invokeArgs($this->filesystem, [$wrongClass, $initialContents]);
+    }
 }