AC-6840:Remove from Constructor Integrity validator check for excess arguments, passed in the parent constructor

Author: faizan-shk

lib/internal/Magento/Framework/Code/Test/Unit/Validator/ConstructorIntegrityTest.php

@@ -52,10 +52,6 @@ public function testValidateIfClassHasArgumentsQtyEqualToParentClass()
 
     public function testValidateIfClassHasExtraArgumentInTheParentConstructor()
     {
-        $fileName = realpath(__DIR__ . '/../_files/app/code/Magento/SomeModule/Model/Four/Test.php');
-        $fileName = str_replace('\\', '/', $fileName);
-        $this->expectException(ValidatorException::class);
-        $this->expectExceptionMessage('Extra parameters passed to parent construct: $factory. File: ' . $fileName);
         $this->_model->validate(\Magento\SomeModule\Model\Four\Test::class);
     }
 

lib/internal/Magento/Framework/Code/Validator/ConstructorIntegrity.php

@@ -89,25 +89,6 @@ public function validate($className)
             }
         }
 
-        /**
-         * Try to detect unused arguments
-         * Check whether count of passed parameters less or equal that count of count parent class arguments
-         */
-        if (count($callArguments) > count($parentArguments)) {
-            $extraParameters = array_slice($callArguments, count($parentArguments));
-            $names = [];
-            foreach ($extraParameters as $param) {
-                $names[] = '$' . $param['name'];
-            }
-
-            $classPath = str_replace('\\', '/', $class->getFileName());
-            throw new \Magento\Framework\Exception\ValidatorException(
-                new Phrase(
-                    'Extra parameters passed to parent construct: %1. File: %2',
-                    [implode(', ', $names), $classPath]
-                )
-            );
-        }
         return true;
     }
 
@@ -142,7 +123,7 @@ private function checkCompatibleTypes(
     }
 
     /**
-     * Check if argument argument is optional
+     * Check if required argument is optional
      *
      * @param array $requiredArgument
      * @param \ReflectionClass $class