Fixed static test failrues

engcom-Echo · engcom-Echo · commit 4771b770864c · 2024-06-11T11:47:11.000+05:30
diff --git a/app/code/Magento/Sales/Model/ResourceModel/Report.php b/app/code/Magento/Sales/Model/ResourceModel/Report.php
@@ -14,6 +14,7 @@ class Report extends \Magento\Sales\Model\ResourceModel\EntityAbstract
      * Resource initialization
      *
      * @return void
+     * phpcs:disable Magento2.CodeAnalysis.EmptyBlock
      */
     protected function _construct()
     {
diff --git a/app/code/Magento/Sales/Model/ResourceModel/Report/Collection/AbstractCollection.php b/app/code/Magento/Sales/Model/ResourceModel/Report/Collection/AbstractCollection.php
@@ -11,8 +11,6 @@
 class AbstractCollection extends \Magento\Reports\Model\ResourceModel\Report\Collection\AbstractCollection
 {
     /**
-     * Order status
-     *
      * @var string
      */
     protected $_orderStatus = null;
diff --git a/app/code/Magento/Sales/Model/ResourceModel/Report/Invoiced/Collection/Order.php b/app/code/Magento/Sales/Model/ResourceModel/Report/Invoiced/Collection/Order.php
@@ -11,8 +11,6 @@
 class Order extends \Magento\Sales\Model\ResourceModel\Report\Collection\AbstractCollection
 {
     /**
-     * Period format
-     *
      * @var string
      */
     protected $_periodFormat;
@@ -82,6 +80,8 @@ protected function _getSelectedColumns()
     }
 
     /**
+     * Before load
+     *
      * @return $this
      */
     protected function _beforeLoad()
diff --git a/app/code/Magento/Sales/Model/ResourceModel/Report/Order/Collection.php b/app/code/Magento/Sales/Model/ResourceModel/Report/Order/Collection.php
@@ -11,8 +11,6 @@
 class Collection extends \Magento\Sales\Model\ResourceModel\Report\Collection\AbstractCollection
 {
     /**
-     * Period format
-     *
      * @var string
      */
     protected $_periodFormat;
@@ -25,8 +23,6 @@ class Collection extends \Magento\Sales\Model\ResourceModel\Report\Collection\Ab
     protected $_aggregationTable = 'sales_order_aggregated_created';
 
     /**
-     * Selected columns
-     *
      * @var array
      */
     protected $_selectedColumns = [];
diff --git a/app/code/Magento/Sales/Model/ResourceModel/Report/Refunded/Collection/Order.php b/app/code/Magento/Sales/Model/ResourceModel/Report/Refunded/Collection/Order.php
@@ -11,15 +11,11 @@
 class Order extends \Magento\Sales\Model\ResourceModel\Report\Collection\AbstractCollection
 {
     /**
-     * Period format
-     *
      * @var string
      */
     protected $_periodFormat;
 
     /**
-     * Selected columns
-     *
      * @var array
      */
     protected $_selectedColumns = [];
diff --git a/app/code/Magento/Sales/Model/ResourceModel/Report/Shipping/Collection/Order.php b/app/code/Magento/Sales/Model/ResourceModel/Report/Shipping/Collection/Order.php
@@ -11,15 +11,11 @@
 class Order extends \Magento\Sales\Model\ResourceModel\Report\Collection\AbstractCollection
 {
     /**
-     * Period format
-     *
      * @var string
      */
     protected $_periodFormat;
 
     /**
-     * Selected columns
-     *
      * @var array
      */
     protected $_selectedColumns = [];
diff --git a/app/code/Magento/Sales/Model/Status/ListStatus.php b/app/code/Magento/Sales/Model/Status/ListStatus.php
@@ -87,8 +87,7 @@ public function removeItemsByParams($params)
     }
 
     /**
-     * Removes items at mentioned index/indexes.
-     * Returns items removed.
+     * Removes items at mentioned index/indexes. Returns items removed.
      *
      * @param int|array $indexes
      * @return array
diff --git a/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Coupons.php b/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Coupons.php
@@ -11,39 +11,39 @@
 class Coupons extends \Magento\Framework\View\Element\Template implements \Magento\Backend\Block\Widget\Tab\TabInterface
 {
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getTabLabel()
     {
         return __('Manage Coupon Codes');
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getTabTitle()
     {
         return __('Manage Coupon Codes');
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function canShowTab()
     {
         return true;
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function isHidden()
     {
         return false;
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      * @codeCoverageIgnore
      */
     public function setCanSHow($canShow)
diff --git a/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Coupons/Form.php b/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Coupons/Form.php
@@ -15,8 +15,6 @@
 class Form extends \Magento\Backend\Block\Widget\Form\Generic
 {
     /**
-     * Sales rule coupon
-     *
      * @var \Magento\SalesRule\Helper\Coupon
      */
     protected $_salesRuleCoupon = null;
diff --git a/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Coupons/Grid/Column/Renderer/Used.php b/app/code/Magento/SalesRule/Block/Adminhtml/Promo/Quote/Edit/Tab/Coupons/Grid/Column/Renderer/Used.php
@@ -11,6 +11,8 @@
 class Used extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\Text
 {
     /**
+     * Render
+     *
      * @param \Magento\Framework\DataObject $row
      * @return string
      */
diff --git a/app/code/Magento/SalesRule/Model/Coupon/Massgenerator.php b/app/code/Magento/SalesRule/Model/Coupon/Massgenerator.php
@@ -14,12 +14,12 @@ class Massgenerator extends \Magento\Framework\Model\AbstractModel implements
     /**
      * Maximum probability of guessing the coupon on the first attempt
      */
-    const MAX_PROBABILITY_OF_GUESSING = 0.25;
+    public const MAX_PROBABILITY_OF_GUESSING = 0.25;
 
     /**
      * Number of attempts to generate
      */
-    const MAX_GENERATE_ATTEMPTS = 10;
+    public const MAX_GENERATE_ATTEMPTS = 10;
 
     /**
      * Count of generated Coupons
@@ -33,8 +33,6 @@ class Massgenerator extends \Magento\Framework\Model\AbstractModel implements
     protected $generatedCodes = [];
 
     /**
-     * Sales rule coupon
-     *
      * @var \Magento\SalesRule\Helper\Coupon
      */
     protected $salesRuleCoupon;
diff --git a/app/code/Magento/SalesRule/Model/ResourceModel/Report/Collection.php b/app/code/Magento/SalesRule/Model/ResourceModel/Report/Collection.php
@@ -48,8 +48,8 @@ class Collection extends \Magento\Sales\Model\ResourceModel\Report\Collection\Ab
      * @param \Psr\Log\LoggerInterface $logger
      * @param \Magento\Framework\Data\Collection\Db\FetchStrategyInterface $fetchStrategy
      * @param \Magento\Framework\Event\ManagerInterface $eventManager
-     * @param \Magento\SalesRule\Model\ResourceModel\Report\RuleFactory $ruleFactory
      * @param \Magento\Sales\Model\ResourceModel\Report $resource
+     * @param \Magento\SalesRule\Model\ResourceModel\Report\RuleFactory $ruleFactory
      * @param mixed $connection
      */
     public function __construct(

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@ class Report extends \Magento\Sales\Model\ResourceModel\EntityAbstract`
`14`	`14`	`* Resource initialization`
`15`	`15`	`*`
`16`	`16`	`* @return void`
	`17`	`+ * phpcs:disable Magento2.CodeAnalysis.EmptyBlock`
`17`	`18`	`*/`
`18`	`19`	`protected function _construct()`
`19`	`20`	`{`
Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,6 @@`
`11`	`11`	`class AbstractCollection extends \Magento\Reports\Model\ResourceModel\Report\Collection\AbstractCollection`
`12`	`12`	`{`
`13`	`13`	`/**`
`14`		`- * Order status`
`15`		`- *`
`16`	`14`	`* @var string`
`17`	`15`	`*/`
`18`	`16`	`protected $_orderStatus = null;`
Original file line number	Diff line number	Diff line change
`@@ -87,8 +87,7 @@ public function removeItemsByParams($params)`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`/**`
`90`		`- * Removes items at mentioned index/indexes.`
`91`		`- * Returns items removed.`
	`90`	`+ * Removes items at mentioned index/indexes. Returns items removed.`
`92`	`91`	`*`
`93`	`92`	`* @param int\|array $indexes`
`94`	`93`	`* @return array`
Original file line number	Diff line number	Diff line change
`@@ -11,39 +11,39 @@`
`11`	`11`	`class Coupons extends \Magento\Framework\View\Element\Template implements \Magento\Backend\Block\Widget\Tab\TabInterface`
`12`	`12`	`{`
`13`	`13`	`/**`
`14`		`- * {@inheritdoc}`
	`14`	`+ * @inheritdoc`
`15`	`15`	`*/`
`16`	`16`	`public function getTabLabel()`
`17`	`17`	`{`
`18`	`18`	`return __('Manage Coupon Codes');`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`/**`
`22`		`- * {@inheritdoc}`
	`22`	`+ * @inheritdoc`
`23`	`23`	`*/`
`24`	`24`	`public function getTabTitle()`
`25`	`25`	`{`
`26`	`26`	`return __('Manage Coupon Codes');`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`/**`
`30`		`- * {@inheritdoc}`
	`30`	`+ * @inheritdoc`
`31`	`31`	`*/`
`32`	`32`	`public function canShowTab()`
`33`	`33`	`{`
`34`	`34`	`return true;`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`/**`
`38`		`- * {@inheritdoc}`
	`38`	`+ * @inheritdoc`
`39`	`39`	`*/`
`40`	`40`	`public function isHidden()`
`41`	`41`	`{`
`42`	`42`	`return false;`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`/**`
`46`		`- * {@inheritdoc}`
	`46`	`+ * @inheritdoc`
`47`	`47`	`* @codeCoverageIgnore`
`48`	`48`	`*/`
`49`	`49`	`public function setCanSHow($canShow)`
Original file line number	Diff line number	Diff line change
`@@ -15,8 +15,6 @@`
`15`	`15`	`class Form extends \Magento\Backend\Block\Widget\Form\Generic`
`16`	`16`	`{`
`17`	`17`	`/**`
`18`		`- * Sales rule coupon`
`19`		`- *`
`20`	`18`	`* @var \Magento\SalesRule\Helper\Coupon`
`21`	`19`	`*/`
`22`	`20`	`protected $_salesRuleCoupon = null;`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,8 @@`
`11`	`11`	`class Used extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\Text`
`12`	`12`	`{`
`13`	`13`	`/**`
	`14`	`+ * Render`
	`15`	`+ *`
`14`	`16`	`* @param \Magento\Framework\DataObject $row`
`15`	`17`	`* @return string`
`16`	`18`	`*/`