ENGCOM-7722: #28580: False positive behavior of testQueryCustomAtt… #28743

Author: cpartica

dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/ProductViewTest.php

@@ -665,7 +665,8 @@ private function assertMediaGalleryEntries($product, $actualResponse)
     {
         $mediaGalleryEntries = $product->getMediaGalleryEntries();
         $this->assertCount(1, $mediaGalleryEntries, "Precondition failed, incorrect number of media gallery entries.");
-        $this->assertIsArray([$actualResponse['media_gallery_entries']],
+        $this->assertIsArray(
+            [$actualResponse['media_gallery_entries']],
             "Media galleries field must be of an array type."
         );
         $this->assertCount(1, $actualResponse['media_gallery_entries'], "There must be 1 record in media gallery.");
@@ -701,10 +702,10 @@ private function assertMediaGalleryEntries($product, $actualResponse)
      */
     private function assertCustomAttribute($actualResponse)
     {
-        $customAttribute = null;
+        $customAttribute = 'customAttributeValue';
         $this->assertEquals($customAttribute, $actualResponse['attribute_code_custom']);
     }
-    
+
     /**
      * @param ProductInterface $product
      * @param $actualResponse

dev/tests/integration/testsuite/Magento/Catalog/_files/product_simple_with_custom_attribute.php

@@ -20,6 +20,9 @@
 $entityTypeId = $entityModel->setType(\Magento\Catalog\Model\Product::ENTITY)->getTypeId();
 $groupId = $installer->getDefaultAttributeGroupId($entityTypeId, $attributeSetId);
 
+/** @var \Magento\Catalog\Model\Product $product */
+$product = $productRepository->get('simple', true);
+
 /** @var $attribute \Magento\Catalog\Model\ResourceModel\Eav\Attribute */
 $attribute = $objectManager->create(\Magento\Catalog\Model\ResourceModel\Eav\Attribute::class);
 $attribute->setAttributeCode(
@@ -30,6 +33,8 @@
     'text'
 )->setFrontendLabel(
     'custom_attributes_frontend_label'
+)->setAttributeSetId(
+    $product->getDefaultAttributeSetId()
 )->setAttributeGroupId(
     $groupId
 )->setIsFilterable(
@@ -40,8 +45,6 @@
     $attribute->getBackendTypeByInput($attribute->getFrontendInput())
 )->save();
 
-$product = $productRepository->get('simple', true);
-
 $product->setCustomAttribute($attribute->getAttributeCode(), 'customAttributeValue');
 
 $productRepository->save($product);