ACP2E-1388:Bundle Products Not Combining Simple Product Prices When Set to Dynamic Pricing

 fixed CR feedback

Author: aplapana

app/code/Magento/Bundle/Model/Plugin/ProductPriceIndexModifier.php

@@ -130,7 +130,6 @@ private function filterProductsFromDynamicPriceBundle(string $priceTableName, ar
         );
         $select->where('selection.product_id IN (?)', $productIds);
         $select->where('product.type_id = ?', Type::TYPE_BUNDLE);
-        $select->group('selection.product_id');
         $bundleProducts = $connection->fetchAll($select);
 
         if (empty($bundleProducts)) {
@@ -139,7 +138,7 @@ private function filterProductsFromDynamicPriceBundle(string $priceTableName, ar
 
         $filteredProducts = [];
         foreach($bundleProducts as $bundle) {
-            if ($bundle['bundle_price_type'] !== Price::PRICE_TYPE_DYNAMIC) {
+            if ($bundle['bundle_price_type'] != Price::PRICE_TYPE_DYNAMIC) {
                 $filteredProducts[] = $bundle['child_product_id'];
             }
         }

app/code/Magento/Bundle/Test/Unit/Model/Plugin/ProductPriceIndexModifierTest.php

@@ -98,7 +98,6 @@ public function testAroundModifyPriceFilteredEntities()
             ->method('joinInner');
         $select->expects($this->exactly(2))
             ->method('where');
-        $select->expects($this->once())->method('group')->with('selection.product_id');
         $connection = $this->createMock(AdapterInterface::class);
         $connection->expects($this->once())
             ->method('select')