ACP2E-3340: added unit test and translations

Author: alzota

app/code/Magento/Fedex/Test/Unit/Model/CarrierTest.php

@@ -143,10 +143,6 @@ protected function setUp(): void
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
 
-        $this->scope->expects($this->any())
-            ->method('getValue')
-            ->willReturnCallback([$this, 'scopeConfigGetValue']);
-
         $countryFactory = $this->getCountryFactory();
         $rateFactory = $this->getRateFactory();
         $storeManager = $this->getStoreManager();
@@ -293,6 +289,11 @@ public function testRequestToShipmentSuccess(): void
         ];
         $storeId = 1;
         $phoneNumber = '1234567890';
+
+        $this->scope->expects($this->any())
+            ->method('getValue')
+            ->willReturnCallback([$this, 'scopeConfigGetValue']);
+
         $request->expects($this->once())->method('getPackages')->willReturn($packages);
         $request->expects($this->exactly(3))->method('getStoreId')->willReturn($storeId);
         $request->expects($this->once())->method('setPackageId');
@@ -355,6 +356,10 @@ public function testRequestToShipmentSuccess(): void
 
     public function testSetRequestWithoutCity(): void
     {
+        $this->scope->expects($this->any())
+            ->method('getValue')
+            ->willReturnCallback([$this, 'scopeConfigGetValue']);
+
         $request = $this->getMockBuilder(RateRequest::class)
             ->disableOriginalConstructor()
             ->addMethods(['getDestCity'])
@@ -367,6 +372,10 @@ public function testSetRequestWithoutCity(): void
 
     public function testSetRequestWithCity(): void
     {
+        $this->scope->expects($this->any())
+            ->method('getValue')
+            ->willReturnCallback([$this, 'scopeConfigGetValue']);
+
         $request = $this->getMockBuilder(RateRequest::class)
             ->disableOriginalConstructor()
             ->addMethods(['getDestCity'])
@@ -391,8 +400,31 @@ public function scopeConfigGetValue(string $path): int|string|null
             'carriers/fedex/debug' => 1,
             'carriers/fedex/api_key' => 'TestApiKey',
             'carriers/fedex/secret_key' => 'TestSecretKey',
+            'carriers/fedex/enabled_tracking_api' => 0,
+            'carriers/fedex/rest_sandbox_webservices_url' => 'https://rest.sandbox.url/',
+            'carriers/fedex/rest_production_webservices_url' => 'https://rest.production.url/'
+        ];
+
+        return $pathMap[$path] ?? null;
+    }
+
+    /**
+     * @param string $path
+     * @return int|string|null
+     */
+    public function scopeConfigGetValueForTracking(string $path): int|string|null
+    {
+        $pathMap = [
+            'carriers/fedex/showmethod' => 1,
+            'carriers/fedex/allowed_methods' => 'ServiceType',
+            'carriers/fedex/debug' => 1,
+            'carriers/fedex/api_key' => 'TestApiKey',
+            'carriers/fedex/secret_key' => 'TestSecretKey',
+            'carriers/fedex/enabled_tracking_api' => 1,
+            'carriers/fedex/tracking_api_key' => 'TestTrackingApiKey',
+            'carriers/fedex/tracking_api_secret_key' => 'TestTrackingSecretKey',
             'carriers/fedex/rest_sandbox_webservices_url' => 'https://rest.sandbox.url/',
-            'carriers/fedex/rest_production_webservices_url' => 'https://rest.production.url/',
+            'carriers/fedex/rest_production_webservices_url' => 'https://rest.production.url/'
         ];
 
         return $pathMap[$path] ?? null;
@@ -417,6 +449,10 @@ public function testCollectRatesRateAmountOriginBased(
             ->method('isSetFlag')
             ->willReturn(true);
 
+        $this->scope->expects($this->any())
+            ->method('getValue')
+            ->willReturnCallback([$this, 'scopeConfigGetValue']);
+
         $accessTokenResponse = $this->getAccessToken();
         $rateResponse = $this->getRateResponse($amount, $currencyCode, $rateType);
 
@@ -503,6 +539,10 @@ public function testCollectRatesErrorMessage(): void
             ->method('isSetFlag')
             ->willReturn(false);
 
+        $this->scope->expects($this->any())
+            ->method('getValue')
+            ->willReturnCallback([$this, 'scopeConfigGetValue']);
+
         $this->error->expects($this->once())
             ->method('setCarrier')
             ->with('fedex');
@@ -881,14 +921,25 @@ public function getAccessToken(): array
      * @param string $shipTimeStamp
      * @param string $expectedDate
      * @param string $expectedTime
+     * @param bool $trackingEnabled
      * @dataProvider shipDateDataProvider
      */
-    public function testGetTracking($tracking, $shipTimeStamp, $expectedDate, $expectedTime): void
+    public function testGetTracking($tracking, $shipTimeStamp, $expectedDate, $expectedTime, $trackingEnabled): void
     {
         $trackRequest = $this->getTrackRequest($tracking);
         $trackResponse = $this->getTrackResponse($shipTimeStamp, $expectedDate, $expectedTime);
         $accessTokenResponse = $this->getAccessToken();
 
+        if ($trackingEnabled) {
+            $this->scope->expects($this->atLeast(1))
+                ->method('getValue')
+                ->willReturnCallback([$this, 'scopeConfigGetValueForTracking']);
+        } else {
+            $this->scope->expects($this->any())
+                ->method('getValue')
+                ->willReturnCallback([$this, 'scopeConfigGetValue']);
+        }
+
         $this->serializer->method('serialize')->willReturn(json_encode($trackRequest));
         $this->serializer->expects($this->any())
             ->method('unserialize')
@@ -942,50 +993,67 @@ public static function shipDateDataProvider(): array
                 'shipTimestamp' => '2020-08-15T02:06:35+03:00',
                 'expectedDate' => '2014-01-09',
                 '18:31:00',
-                0,
+                false,
+                0
             ],
             'tracking1-again' => [
                 'tracking1',
                 'shipTimestamp' => '2014-01-09T02:06:35+03:00',
                 'expectedDate' => '2014-01-09',
                 '18:31:00',
-                0,
+                false,
+                0
             ],
             'tracking2' => [
                 'tracking2',
                 'shipTimestamp' => '2014-01-09T02:06:35+03:00',
                 'expectedDate' => '2014-01-09',
                 '23:06:35',
+                false,
+                0
             ],
             'tracking3' => [
                 'tracking3',
                 'shipTimestamp' => '2014-01-09T14:06:35',
                 'expectedDate' => '2014-01-09',
                 '18:31:00',
+                false,
+                0
             ],
             'tracking4' => [
                 'tracking4',
                 'shipTimestamp' => '2016-08-05 14:06:35',
                 'expectedDate' => null,
-                null,
+                '',
+                false,
             ],
             'tracking5' => [
                 'tracking5',
                 'shipTimestamp' => '2016-08-05 14:06:35+00:00',
                 'expectedDate' => null,
-                null,
+                '',
+                false,
             ],
             'tracking6' => [
                 'tracking6',
                 'shipTimestamp' => '2016-08-05',
                 'expectedDate' => null,
-                null,
+                '',
+                false,
             ],
             'tracking7' => [
                 'tracking7',
                 'shipTimestamp' => '2016/08/05',
                 'expectedDate' => null,
-                null
+                '',
+                false,
+            ],
+            'tracking8' => [
+                'tracking8',
+                'shipTimestamp' => '2024-09-19T02:06:35+03:00',
+                'expectedDate' => '2024-09-21',
+                '18:31:00',
+                true
             ],
         ];
     }

app/code/Magento/Fedex/i18n/en_US.csv

@@ -88,3 +88,8 @@ Debug,Debug
 "Package Return Program","Package Return Program"
 "Regular Stop","Regular Stop"
 "Tag","Tag"
+"Api Key","Api Key"
+"Secret Key","Secret Key"
+"Enable Tracking API credentials","Enable Tracking API credentials"
+"Tracking API Key","Tracking API Key"
+"Tracking API Secret Key","Tracking API Secret Key"