ENGCOM-2793: [Forwardport] 6305 - Resolved product custom option title save issue #17607

Author: Stanislav Idolov

app/code/Magento/Catalog/Model/Product/Option/Validator/DefaultValidator.php

@@ -107,8 +107,8 @@ protected function isValidOptionTitle($title, $storeId)
             return true;
         }
 
-        // checking whether title is null and also changed is_empty to is_null
-        if ($title === null) {
+        // checking whether title is null and is empty string
+        if ($title === null || $title === '') {
             return false;
         }
 

dev/tests/api-functional/testsuite/Magento/Catalog/Api/ProductCustomOptionRepositoryTest.php

@@ -208,7 +208,7 @@ public function testAddNegative($optionData)
         ];
 
         if (TESTS_WEB_API_ADAPTER == self::ADAPTER_SOAP) {
-            if (isset($optionDataPost['title']) && empty($optionDataPost['title'])) {
+            if ($optionDataPost['title'] === null || $optionDataPost['title'] === '') {
                 $this->expectException('SoapFault');
                 $this->expectExceptionMessage('Missed values for option required fields');
             } else {

dev/tests/api-functional/testsuite/Magento/Catalog/Api/_files/product_options_negative.php

@@ -6,7 +6,7 @@
 
 return [
     'empty_required_field' => [
-        'title' => '',
+        'title' => null,
         'type' => 'field',
         'sort_order' => 1,
         'is_require' => 1,
@@ -54,7 +54,7 @@
                 'price' => 10.0,
                 'price_type' => 'fixed',
                 'sku' => 'radio option 1 sku',
-                'title' => '',
+                'title' => null,
                 'sort_order' => 1,
             ],
         ],