ENGCOM-5499: class ApplyAttributesUpdate should use \Magento\Catalog\Model\Product\Type::TYPE_BUNDLE instead of fixing "bundle" #23919

Author: sidolov

app/code/Magento/Bundle/Setup/Patch/Data/ApplyAttributesUpdate.php

@@ -14,8 +14,7 @@
 use Magento\Eav\Setup\EavSetupFactory;
 
 /**
- * Class ApplyAttributesUpdate
- * @package Magento\Bundle\Setup\Patch
+ * Class \Magento\Bundle\Setup\Patch\ApplyAttributesUpdate
  */
 class ApplyAttributesUpdate implements DataPatchInterface, PatchVersionInterface
 {
@@ -44,7 +43,7 @@ public function __construct(
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
     public function apply()
@@ -66,8 +65,8 @@ public function apply()
                 ',',
                 $eavSetup->getAttribute(\Magento\Catalog\Model\Product::ENTITY, $field, 'apply_to')
             );
-            if (!in_array('bundle', $applyTo)) {
-                $applyTo[] = 'bundle';
+            if (!in_array(\Magento\Catalog\Model\Product\Type::TYPE_BUNDLE, $applyTo)) {
+                $applyTo[] = \Magento\Catalog\Model\Product\Type::TYPE_BUNDLE;
                 $eavSetup->updateAttribute(
                     \Magento\Catalog\Model\Product::ENTITY,
                     $field,
@@ -78,7 +77,7 @@ public function apply()
         }
 
         $applyTo = explode(',', $eavSetup->getAttribute(\Magento\Catalog\Model\Product::ENTITY, 'cost', 'apply_to'));
-        unset($applyTo[array_search('bundle', $applyTo)]);
+        unset($applyTo[array_search(\Magento\Catalog\Model\Product\Type::TYPE_BUNDLE, $applyTo)]);
         $eavSetup->updateAttribute(\Magento\Catalog\Model\Product::ENTITY, 'cost', 'apply_to', implode(',', $applyTo));
 
         /**
@@ -106,7 +105,7 @@ public function apply()
                 'visible_on_front' => false,
                 'used_in_product_listing' => true,
                 'unique' => false,
-                'apply_to' => 'bundle'
+                'apply_to' => \Magento\Catalog\Model\Product\Type::TYPE_BUNDLE
             ]
         );
 
@@ -131,7 +130,7 @@ public function apply()
                 'comparable' => false,
                 'visible_on_front' => false,
                 'unique' => false,
-                'apply_to' => 'bundle'
+                'apply_to' => \Magento\Catalog\Model\Product\Type::TYPE_BUNDLE
             ]
         );
 
@@ -157,7 +156,7 @@ public function apply()
                 'visible_on_front' => false,
                 'used_in_product_listing' => true,
                 'unique' => false,
-                'apply_to' => 'bundle'
+                'apply_to' => \Magento\Catalog\Model\Product\Type::TYPE_BUNDLE
             ]
         );
 
@@ -184,7 +183,7 @@ public function apply()
                 'visible_on_front' => false,
                 'used_in_product_listing' => true,
                 'unique' => false,
-                'apply_to' => 'bundle'
+                'apply_to' => \Magento\Catalog\Model\Product\Type::TYPE_BUNDLE
             ]
         );
 
@@ -210,29 +209,29 @@ public function apply()
                 'visible_on_front' => false,
                 'used_in_product_listing' => true,
                 'unique' => false,
-                'apply_to' => 'bundle'
+                'apply_to' => \Magento\Catalog\Model\Product\Type::TYPE_BUNDLE
             ]
         );
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public static function getDependencies()
     {
         return [];
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public static function getVersion()
     {
         return '2.0.0';
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getAliases()
     {