ACP2E-782: Introduce an alternative way to define fixtures using PHP8 Attributes

Author: bubasuma

dev/tests/integration/framework/Magento/TestFramework/Annotation/AbstractDataFixture.php

@@ -270,7 +270,7 @@ protected function getParsers(): array
     protected function getDbIsolationState(TestCase $test)
     {
         $isEnabled = Bootstrap::getObjectManager()->get(DbIsolationState::class)->isEnabled($test);
-        return $isEnabled === null ? null : [$isEnabled];
+        return $isEnabled === null ? null : [$isEnabled ? 'enabled' : 'disabled'];
     }
 
     /**

dev/tests/integration/framework/Magento/TestFramework/Annotation/IndexerDimensionMode.php

@@ -114,13 +114,15 @@ public function startTest(TestCase $test)
 
         $dbIsolation = Bootstrap::getObjectManager()->get(DbIsolationState::class)->isEnabled($test);
 
-        if ($dbIsolation) {
-            $this->fail("@magentoDbIsolation must be disabled when using @magentoIndexerDimensionMode", $test);
-        }
-
-        if ($values && $values[0]['indexer'] === Processor::INDEXER_ID) {
-            $this->isDimensionMode = true;
-            $this->setDimensionMode($values[0]['dimension'], $test);
+        if ($values) {
+            if ($dbIsolation) {
+                $this->fail("@magentoDbIsolation must be disabled when using @magentoIndexerDimensionMode", $test);
+            }
+
+            if ($values[0]['indexer'] === Processor::INDEXER_ID) {
+                $this->isDimensionMode = true;
+                $this->setDimensionMode($values[0]['dimension'], $test);
+            }
         }
     }
 
@@ -148,40 +150,4 @@ private function fail($message, TestCase $test)
     {
         $test->fail("{$message} in the test '{$test->toString()}'");
     }
-
-    /**
-     * Returns fixtures defined using IndexerDimensionMode annotation
-     *
-     * @param TestCase $test
-     * @param string $scope
-     * @return array
-     * @throws \Exception
-     */
-    private function getFixturesFromAnnotation(TestCase $test, string $scope): array
-    {
-        $annotations = TestCaseAnnotation::getInstance()->getAnnotations($test);
-        $configs = [];
-
-        foreach ($annotations[$scope][self::ANNOTATION] ?? [] as $annotation) {
-            $parts = explode(' ', $annotation);
-            $configs[] = ['indexer' => $parts[0], 'dimension' => $parts[1]];
-        }
-
-        return $configs;
-    }
-
-    /**
-     * Returns fixtures defined using IndexerDimensionMode attribute
-     *
-     * @param TestCase $test
-     * @param string $scope
-     * @return array
-     * @throws LocalizedException
-     */
-    private function getFixturesFromAttribute(TestCase $test, string $scope): array
-    {
-        return Bootstrap::getObjectManager()
-            ->create(\Magento\TestFramework\Fixture\Parser\IndexerDimensionMode::class)
-            ->parse($test, $scope);
-    }
 }

dev/tests/integration/framework/Magento/TestFramework/Annotation/Parser/AppIsolation.php

@@ -33,7 +33,7 @@ public function parse(TestCase $test, string $scope): array
                     __('Invalid "@%1" annotation, can be "enabled" or "disabled" only.', self::ANNOTATION)
                 );
             }
-            $values[] = ['state' => $value === 'enabled'];
+            $values[] = ['enabled' => $value === 'enabled'];
         }
 
         return $values;

dev/tests/integration/framework/Magento/TestFramework/Annotation/Parser/DbIsolation.php

@@ -33,7 +33,7 @@ public function parse(TestCase $test, string $scope): array
                     __('Invalid "@%1" annotation, can be "enabled" or "disabled" only.', self::ANNOTATION)
                 );
             }
-            $values[] = ['state' => $value === 'enabled'];
+            $values[] = ['enabled' => $value === 'enabled'];
         }
 
         return $values;