MCP-946: Price Index Optimization

-Fix Static tests;

Author: aa-kashk

app/code/Magento/Bundle/Model/ResourceModel/Indexer/Price/DisabledProductOptionPriceModifier.php

@@ -136,7 +136,8 @@ private function isBundle(int $entityId): bool
         return $this->isBundle[$entityId];
     }
 
-    /**
+    /** Get Bundle Ids
+     *
      * @param array $entityIds
      * @return \Traversable
      */

app/code/Magento/Catalog/Model/Indexer/Product/Price/AbstractAction.php

@@ -61,7 +61,6 @@ abstract class AbstractAction
     protected $_storeManager;
 
     /**
-     * Currency factory
      *
      * @var CurrencyFactory
      */
@@ -83,7 +82,6 @@ abstract class AbstractAction
     protected $_catalogProductType;
 
     /**
-     * Indexer price factory
      *
      * @var Factory
      */

app/code/Magento/Catalog/Model/ResourceModel/Product/Indexer/Price/Query/BaseFinalPrice.php

@@ -136,7 +136,6 @@ public function getQuery(array $dimensions, string $productType, array $entityId
             $taxClassId = new \Zend_Db_Expr(0);
         }
 
-
         $this->joinAttributeProcessor->process($select, 'status', Status::STATUS_ENABLED);
 
         $price = $this->joinAttributeProcessor->process($select, 'price');
@@ -169,10 +168,10 @@ public function getQuery(array $dimensions, string $productType, array $entityId
             ['cg' => $this->getTable('customer_group')],
             array_key_exists(CustomerGroupDimensionProvider::DIMENSION_NAME, $dimensions)
                 ? sprintf(
-                '%s = %s',
-                $this->dimensionToFieldMapper[CustomerGroupDimensionProvider::DIMENSION_NAME],
-                $dimensions[CustomerGroupDimensionProvider::DIMENSION_NAME]->getValue()
-            ) : '',
+                    '%s = %s',
+                    $this->dimensionToFieldMapper[CustomerGroupDimensionProvider::DIMENSION_NAME],
+                    $dimensions[CustomerGroupDimensionProvider::DIMENSION_NAME]->getValue()
+                ) : '',
             []
         )->joinLeft(
         // customer group website limitations
@@ -235,8 +234,6 @@ public function getQuery(array $dimensions, string $productType, array $entityId
             $select->where('e.entity_id IN(?)', $entityIds, \Zend_Db::INT_TYPE);
         }
 
-
-
         /**
          * throw event for backward compatibility
          */
@@ -250,8 +247,6 @@ public function getQuery(array $dimensions, string $productType, array $entityId
             ]
         );
 
-       //  static $p; if (!$p) { echo $select; $p =1; }
-       // var_dump(__METHOD__, $connection->query($connection->select()->from((clone $select)->having('customer_group_id = 0'), "COUNT(*)"))->fetchColumn());
         return $select;
     }
 

app/code/Magento/CatalogSearch/Model/Indexer/Fulltext.php

@@ -33,7 +33,7 @@ class Fulltext implements
     /**
      * Indexer ID in configuration
      */
-    const INDEXER_ID = 'catalogsearch_fulltext';
+    public const INDEXER_ID = 'catalogsearch_fulltext';
 
     /**
      * Default batch size

app/code/Magento/CatalogSearch/Model/Indexer/Fulltext/Action/Full.php

@@ -29,7 +29,7 @@ class Full
     /**
      * Scope identifier
      */
-    const SCOPE_FIELD_NAME = 'scope';
+    public const SCOPE_FIELD_NAME = 'scope';
 
     /**
      * Searchable attributes cache
@@ -79,21 +79,18 @@ class Full
     protected $productAttributeCollectionFactory;
 
     /**
-     * Catalog product status
      *
      * @var \Magento\Catalog\Model\Product\Attribute\Source\Status
      */
     protected $catalogProductStatus;
 
     /**
-     * Eav config
      *
      * @var \Magento\Eav\Model\Config
      */
     protected $eavConfig;
 
     /**
-     * Catalog product type
      *
      * @var \Magento\Catalog\Model\Product\Type
      * @deprecated 100.1.0 Moved to \Magento\CatalogSearch\Model\Indexer\Fulltext\Action\DataProvider
@@ -117,7 +114,6 @@ class Full
     protected $scopeConfig;
 
     /**
-     * Store manager
      *
      * @var \Magento\Store\Model\StoreManagerInterface
      * @deprecated 100.1.0 Moved to \Magento\CatalogSearch\Model\Indexer\Fulltext\Action\DataProvider
@@ -231,7 +227,7 @@ class Full
      * @param \Magento\Framework\Search\Request\DimensionFactory $dimensionFactory
      * @param \Magento\Framework\Indexer\ConfigInterface $indexerConfig
      * @param null $indexIteratorFactory
-     * @param \Magento\Framework\EntityManager\MetadataPool|null $metadataPool
+     * @param \Magento\Framework\EntityManager\MetadataPool $metadataPool
      * @param DataProvider|null $dataProvider
      * @param int $batchSize
      * @param DeploymentConfig|null $deploymentConfig

app/code/Magento/GroupedProduct/Model/ResourceModel/Product/Indexer/Price/Grouped.php

@@ -1,7 +1,5 @@
 <?php
 /**
- * Grouped Products Price Indexer Resource model
- *
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */