AC-13346::Deprecation of E_STRICT constant in PHP 8.4

djadobe16 · djadobe16 · commit 363e3eb4aa12 · 2024-11-13T15:05:18.000+05:30
diff --git a/dev/tests/api-functional/framework/bootstrap.php b/dev/tests/api-functional/framework/bootstrap.php
@@ -141,7 +141,6 @@ function ($errNo, $errStr, $errFile, $errLine) {
                     E_USER_ERROR => 'User Error',
                     E_USER_WARNING => 'User Warning',
                     E_USER_NOTICE => 'User Notice',
-                    E_STRICT => 'Strict',
                     E_RECOVERABLE_ERROR => 'Recoverable Error',
                     E_DEPRECATED => 'Deprecated',
                     E_USER_DEPRECATED => 'User Deprecated',
diff --git a/dev/tests/error_handler.php b/dev/tests/error_handler.php
@@ -25,7 +25,6 @@ function ($errNo, $errStr, $errFile, $errLine) {
                     E_USER_ERROR => 'User Error',
                     E_USER_WARNING => 'User Warning',
                     E_USER_NOTICE => 'User Notice',
-                    E_STRICT => 'Strict',
                     E_RECOVERABLE_ERROR => 'Recoverable Error',
                     E_DEPRECATED => 'Deprecated',
                     E_USER_DEPRECATED => 'User Deprecated',
diff --git a/dev/tests/integration/framework/bootstrap.php b/dev/tests/integration/framework/bootstrap.php
@@ -149,7 +149,6 @@ function ($errNo, $errStr, $errFile, $errLine) {
                     E_USER_ERROR => 'User Error',
                     E_USER_WARNING => 'User Warning',
                     E_USER_NOTICE => 'User Notice',
-                    E_STRICT => 'Strict',
                     E_RECOVERABLE_ERROR => 'Recoverable Error',
                     E_DEPRECATED => 'Deprecated',
                     E_USER_DEPRECATED => 'User Deprecated',
diff --git a/dev/tests/static/framework/bootstrap.php b/dev/tests/static/framework/bootstrap.php
@@ -63,7 +63,6 @@ function ($errNo, $errStr, $errFile, $errLine) {
                     E_USER_ERROR => 'User Error',
                     E_USER_WARNING => 'User Warning',
                     E_USER_NOTICE => 'User Notice',
-                    E_STRICT => 'Strict',
                     E_RECOVERABLE_ERROR => 'Recoverable Error',
                     E_DEPRECATED => 'Deprecated',
                     E_USER_DEPRECATED => 'User Deprecated',
diff --git a/dev/tests/unit/framework/bootstrap.php b/dev/tests/unit/framework/bootstrap.php
@@ -54,7 +54,6 @@ function ($errNo, $errStr, $errFile, $errLine) {
                     E_USER_ERROR => 'User Error',
                     E_USER_WARNING => 'User Warning',
                     E_USER_NOTICE => 'User Notice',
-                    E_STRICT => 'Strict',
                     E_RECOVERABLE_ERROR => 'Recoverable Error',
                     E_DEPRECATED => 'Deprecated',
                     E_USER_DEPRECATED => 'User Deprecated',
diff --git a/lib/internal/Magento/Framework/App/ErrorHandler.php b/lib/internal/Magento/Framework/App/ErrorHandler.php
@@ -28,7 +28,6 @@ class ErrorHandler
         E_USER_ERROR => 'User Error',
         E_USER_WARNING => 'User Warning',
         E_USER_NOTICE => 'User Notice',
-        E_STRICT => 'Strict Notice',
         E_RECOVERABLE_ERROR => 'Recoverable Error',
         E_DEPRECATED => 'Deprecated Functionality',
         E_USER_DEPRECATED => 'User Deprecated Functionality',
diff --git a/lib/internal/Magento/Framework/App/Test/Unit/ErrorHandlerTest.php b/lib/internal/Magento/Framework/App/Test/Unit/ErrorHandlerTest.php
@@ -82,7 +82,6 @@ public static function handlerProviderException()
             [E_USER_ERROR, 'User Error'],
             [E_USER_WARNING, 'User Warning'],
             [E_USER_NOTICE, 'User Notice'],
-            [E_STRICT, 'Strict Notice'],
             [E_RECOVERABLE_ERROR, 'Recoverable Error'],
             [E_DEPRECATED, 'Deprecated Functionality'],
             [E_USER_DEPRECATED, 'User Deprecated Functionality'],
diff --git a/setup/src/Magento/Setup/Module/Di/Code/Reader/Decorator/Directory.php b/setup/src/Magento/Setup/Module/Di/Code/Reader/Decorator/Directory.php
@@ -69,7 +69,7 @@ public function __construct(
         $this->validator = $validator;
         $this->generationDir = $generationDir;
 
-        set_error_handler([$this, 'errorHandler'], E_STRICT);
+        set_error_handler([$this, 'errorHandler'], E_NOTICE);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ public function __construct(`
`69`	`69`	`$this->validator = $validator;`
`70`	`70`	`$this->generationDir = $generationDir;`
`71`	`71`
`72`		`- set_error_handler([$this, 'errorHandler'], E_STRICT);`
	`72`	`+ set_error_handler([$this, 'errorHandler'], E_NOTICE);`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`/**`