ACP2E-2204: Price indexing performance gradually degrades overtime

- truncate statement breaks transactions

Author: aplapana

app/code/Magento/Catalog/Model/Indexer/Product/Price/Action/Full.php

@@ -311,7 +311,6 @@ private function reindexByBatchWithDimensions(
         if (!empty($entityIds)) {
             $this->dimensionTableMaintainer->createMainTmpTable($dimensions);
             $temporaryTable = $this->dimensionTableMaintainer->getMainTmpTable($dimensions);
-            $this->_emptyTable($temporaryTable);
 
             $priceIndexer->executeByDimensions($dimensions, \SplFixedArray::fromArray($entityIds, false));
 
@@ -354,7 +353,6 @@ private function reindexBatch(PriceInterface $priceIndexer, Select $batch): void
         if (!empty($entityIds)) {
             // Temporary table will created if not exists
             $idxTableName = $this->_defaultIndexerResource->getIdxTable();
-            $this->_emptyTable($idxTableName);
 
             if ($priceIndexer->getIsComposite()) {
                 $this->_copyRelationIndexData($entityIds);
@@ -494,17 +492,4 @@ protected function getIndexTargetTable(): string
     {
         return $this->activeTableSwitcher->getAdditionalTableName($this->_defaultIndexerResource->getMainTable());
     }
-
-    /**
-     * Removes all data from the table
-     *
-     * @param string $table
-     * @return void
-     */
-    protected function _emptyTable($table): void
-    {
-        $connection = $this->_defaultIndexerResource->getConnection();
-        // phpcs:ignore Magento2.SQL.RawQuery.FoundRawSql
-        $connection->query('TRUNCATE TABLE ' . $connection->quoteIdentifier($table));
-    }
 }

app/code/Magento/Catalog/Model/ResourceModel/Product/Indexer/Price/CustomOptionPriceModifier.php

@@ -122,10 +122,8 @@ public function modifyPrice(IndexTableStructure $priceTable, array $entityIds =
         $query = $select->crossUpdateFromSelect(['i' => $finalPriceTable]);
         $connection->query($query);
 
-        // phpcs:ignore Magento2.SQL.RawQuery.FoundRawSql
-        $connection->query('TRUNCATE TABLE ' . $connection->quoteIdentifier($coaTable));
-        // phpcs:ignore Magento2.SQL.RawQuery.FoundRawSql
-        $connection->query('TRUNCATE TABLE ' . $connection->quoteIdentifier($copTable));
+        $connection->dropTemporaryTable($coaTable);
+        $connection->dropTemporaryTable($copTable);
     }
 
     /**