B2B-2471: Defects in CatalogUrlResolverIdentity and CmsUrlResolverIdentity prevent caching

Author: joanhe

dev/tests/api-functional/testsuite/Magento/GraphQl/PageCache/UrlRewrite/RouteCacheTest.php

@@ -21,6 +21,7 @@
 
 /**
  * Test caching works for url route.
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class RouteCacheTest extends GraphQLPageCacheAbstract
 {
@@ -131,7 +132,7 @@ public function testGetNonExistentUrlRewrite()
 
         /** @var ProductRepositoryInterface $productRepository */
         $productRepository = $this->objectManager->get(ProductRepositoryInterface::class);
-        $product = $productRepository->get($productSku, false, null, true);
+        $productRepository->get($productSku, false, null, true);
 
         /** @var UrlRewriteModel $urlRewriteModel */
         $urlRewriteModel = $this->objectManager->create(UrlRewriteModel::class);
@@ -147,7 +148,6 @@ public function testGetNonExistentUrlRewrite()
 
         // Verify we obtain a cache HIT the second time around for this X-Magento-Cache-Id
         $this->assertCacheHit($routeQuery, [CacheIdCalculator::CACHE_ID_HEADER => $cacheId]);
-
     }
 
     /**
@@ -175,7 +175,7 @@ public function testCategoryUrlResolver()
         );
         $categoryId = $actualUrls->getEntityId();
         $categoryRepository = $this->objectManager->get(CategoryRepositoryInterface::class);
-        $category = $categoryRepository->get($categoryId);
+        $categoryRepository->get($categoryId);
 
         $query
             = <<<QUERY
@@ -195,7 +195,6 @@ public function testCategoryUrlResolver()
 
         // Verify we obtain a cache HIT the second time around for this X-Magento-Cache-Id
         $this->assertCacheHit($query, [CacheIdCalculator::CACHE_ID_HEADER => $cacheId]);
-
     }
 
     /**
@@ -207,7 +206,7 @@ public function testCMSPageUrlResolver()
         /** @var \Magento\Cms\Model\Page $page */
         $page = $this->objectManager->get(\Magento\Cms\Model\Page::class);
         $page->load('page100');
-        $cmsPageData = $page->getData();
+        $page->getData();
 
         /** @var \Magento\CmsUrlRewrite\Model\CmsPageUrlPathGenerator $urlPathGenerator */
         $urlPathGenerator = $this->objectManager->get(\Magento\CmsUrlRewrite\Model\CmsPageUrlPathGenerator::class);
@@ -225,7 +224,6 @@ public function testCMSPageUrlResolver()
 
         // Verify we obtain a cache HIT the second time around for this X-Magento-Cache-Id
         $this->assertCacheHit($routeQuery, [CacheIdCalculator::CACHE_ID_HEADER => $cacheId]);
-
     }
 
     /**