ENGCOM-9074: Do not trigger url rewrites re-generation for all store views #32808

Author: sidolov

app/code/Magento/CatalogUrlRewrite/Model/Category/Plugin/Store/Group.php

@@ -92,6 +92,7 @@ public function afterSave(
         AbstractModel $group
     ) {
         if (!$group->isObjectNew()
+            && $group->getStoreIds()
             && ($group->dataHasChangedFor('website_id')
                 || $group->dataHasChangedFor('root_category_id'))
         ) {

app/code/Magento/CatalogUrlRewrite/Test/Unit/Model/Category/Plugin/Store/GroupTest.php

@@ -88,9 +88,6 @@ protected function setUp(): void
             ->disableOriginalConstructor()
             ->setMethods(['isObjectNew', 'dataHasChangedFor', 'getStoreIds'])
             ->getMockForAbstractClass();
-        $this->abstractModelMock->expects($this->any())
-            ->method('getStoreIds')
-            ->willReturn([]);
         $this->subjectMock = $this->getMockBuilder(Group::class)
             ->disableOriginalConstructor()
             ->getMock();
@@ -138,6 +135,9 @@ public function testAfterSave()
         $this->abstractModelMock->expects($this->once())
             ->method('isObjectNew')
             ->willReturn(false);
+        $this->abstractModelMock->expects($this->any())
+            ->method('getStoreIds')
+            ->willReturn(['1']);
         $this->abstractModelMock->expects($this->once())
             ->method('dataHasChangedFor')
             ->with('website_id')
@@ -179,4 +179,34 @@ public function testAfterSave()
             $this->plugin->afterSave($this->subjectMock, $this->subjectMock, $this->abstractModelMock)
         );
     }
+
+    public function testAfterSaveWithNoStoresAssigned()
+    {
+        $this->abstractModelMock->expects($this->once())
+            ->method('isObjectNew')
+            ->willReturn(false);
+        $this->abstractModelMock->expects($this->any())
+            ->method('getStoreIds')
+            ->willReturn([]);
+        $this->abstractModelMock->expects($this->any())
+            ->method('dataHasChangedFor')
+            ->with('website_id')
+            ->willReturn(true);
+        $this->storeManagerMock->expects($this->never())->method('reinitStores');
+        $this->categoryMock->expects($this->never())->method('getCategories');
+        $this->categoryFactoryMock->expects($this->never())->method('create');
+        $this->productFactoryMock->expects($this->never())->method('create');
+        $this->productMock->expects($this->never())->method('getCollection');
+        $this->productCollectionMock->expects($this->never())->method('addCategoryIds');
+        $this->productCollectionMock->expects($this->never())            ->method('addAttributeToSelect');
+        $this->productCollectionMock->expects($this->never())->method('addWebsiteFilter');
+        $iterator = new \ArrayIterator([$this->productMock]);
+        $this->productCollectionMock->expects($this->never())->method('getIterator');
+        $this->productUrlRewriteGeneratorMock->expects($this->never())->method('generate');
+
+        $this->assertSame(
+            $this->subjectMock,
+            $this->plugin->afterSave($this->subjectMock, $this->subjectMock, $this->abstractModelMock)
+        );
+    }
 }