AC-1989: Fix subset of deprecated php usages

- static tests fixes
- rollback Media.php to avoid unit test failures

Author: xmav

app/code/Magento/Cron/Model/Config/Converter/Db.php

@@ -29,7 +29,7 @@ public function convert($source)
     /**
      * Extract and prepare cron job data
      *
-     * @param array $jobs
+     * @param array $cronTab
      * @return array
      */
     protected function _extractParams(array $cronTab)

app/code/Magento/MediaStorage/App/Media.php

@@ -238,12 +238,7 @@ private function createLocalCopy(): void
      */
     private function checkMediaDirectoryChanged(): bool
     {
-        $isDirectoryChanged = false;
-        if ($this->mediaDirectoryPath && $this->directoryMedia->getAbsolutePath()) {
-            $isDirectoryChanged = rtrim($this->mediaDirectoryPath, '/')
-                !== rtrim($this->directoryMedia->getAbsolutePath(), '/');
-        }
-        return $isDirectoryChanged;
+        return rtrim($this->mediaDirectoryPath, '/') !== rtrim($this->directoryMedia->getAbsolutePath(), '/');
     }
 
     /**

app/code/Magento/Newsletter/Block/Adminhtml/Template/Edit.php

@@ -21,8 +21,6 @@
 class Edit extends Widget
 {
     /**
-     * Core registry
-     *
      * @var \Magento\Framework\Registry
      */
     protected $_coreRegistry = null;
@@ -217,6 +215,7 @@ public function getForm()
     public function getJsTemplateName()
     {
         $templateCode = $this->getModel()->getTemplateCode();
+        //phpcs:ignore Magento2.Functions.DiscouragedFunction
         return $templateCode ? addcslashes($templateCode, "\"\r\n\\") : '';
     }
 

app/code/Magento/SalesRule/Model/Quote/Discount.php

@@ -33,7 +33,7 @@
  */
 class Discount extends AbstractTotal
 {
-    const COLLECTOR_TYPE_CODE = 'discount';
+    public const COLLECTOR_TYPE_CODE = 'discount';
 
     /**
      * Discount calculation object

lib/internal/Magento/Framework/App/Utility/Files.php

@@ -24,26 +24,26 @@
  */
 class Files
 {
-    const INCLUDE_APP_CODE = 1;
+    public const INCLUDE_APP_CODE = 1;
 
-    const INCLUDE_TESTS = 2;
+    public const INCLUDE_TESTS = 2;
 
-    const INCLUDE_DEV_TOOLS = 4;
+    public const INCLUDE_DEV_TOOLS = 4;
 
-    const INCLUDE_TEMPLATES = 8;
+    public const INCLUDE_TEMPLATES = 8;
 
-    const INCLUDE_LIBS = 16;
+    public const INCLUDE_LIBS = 16;
 
-    const INCLUDE_PUB_CODE = 32;
+    public const INCLUDE_PUB_CODE = 32;
 
-    const INCLUDE_NON_CLASSES = 64;
+    public const INCLUDE_NON_CLASSES = 64;
 
-    const INCLUDE_SETUP = 128;
+    public const INCLUDE_SETUP = 128;
 
     /**
      * Return as data set
      */
-    const AS_DATA_SET = 1024;
+    public const AS_DATA_SET = 1024;
 
     /**
      * @var ComponentRegistrar