Merge remote-tracking branch 'adobe-commerce-tier-4/ACP2E-2978' into Tier4-Kings-PR-05-17-2024

Author: glanujnehra

app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper.php

@@ -23,6 +23,7 @@
 use Magento\Catalog\Ui\DataProvider\Product\Form\Modifier\CustomOptions;
 use Magento\Framework\App\ObjectManager;
 use Magento\Framework\App\RequestInterface;
+use Magento\Framework\Exception\NoSuchEntityException;
 use Magento\Framework\Locale\FormatInterface;
 use Magento\Framework\Stdlib\DateTime\Filter\Date;
 use Magento\Store\Model\StoreManagerInterface;
@@ -279,6 +280,7 @@ public function initialize(Product $product)
      * @param Product $product
      * @return Product
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     * @throws NoSuchEntityException
      * @since 101.0.0
      */
     protected function setProductLinks(Product $product)
@@ -302,20 +304,18 @@ protected function setProductLinks(Product $product)
         }
 
         foreach ($linkTypes as $linkType => $readonly) {
-            if (isset($links[$linkType]) && !$readonly) {
-                foreach ((array) $links[$linkType] as $linkData) {
-                    if (empty($linkData['id'])) {
-                        continue;
-                    }
-
-                    $linkProduct = $this->productRepository->getById($linkData['id']);
-                    $link = $this->productLinkFactory->create();
-                    $link->setSku($product->getSku())
-                        ->setLinkedProductSku($linkProduct->getSku())
-                        ->setLinkType($linkType)
-                        ->setPosition(isset($linkData['position']) ? (int) $linkData['position'] : 0);
-                    $productLinks[] = $link;
-                }
+            $isReadOnlyLinks = $readonly && in_array($linkType, ['upsell', 'related']);
+            if ($isReadOnlyLinks) {
+                $productLinks = null;
+                break;
+            } else {
+                $productLinks = $this->setProductLinksForNotReadOnlyItems(
+                    $productLinks,
+                    $product,
+                    $links,
+                    $linkType,
+                    $readonly
+                );
             }
         }
 
@@ -527,4 +527,39 @@ private function setCategoryLinks(Product $product): void
         $extensionAttributes->setCategoryLinks(!empty($newCategoryLinks) ? $newCategoryLinks : null);
         $product->setExtensionAttributes($extensionAttributes);
     }
+
+    /**
+     * Set product links when readonly is false
+     *
+     * @param array $productLinks
+     * @param Product $product
+     * @param array $links
+     * @param string $linkType
+     * @param mixed $readonly
+     * @return array
+     * @throws NoSuchEntityException
+     */
+    private function setProductLinksForNotReadOnlyItems(
+        array $productLinks,
+        Product $product,
+        array $links,
+        string $linkType,
+        mixed $readonly
+    ): array {
+        if (isset($links[$linkType]) && !$readonly) {
+            foreach ((array)$links[$linkType] as $linkData) {
+                if (empty($linkData['id'])) {
+                    continue;
+                }
+                $linkProduct = $this->productRepository->getById($linkData['id']);
+                $link = $this->productLinkFactory->create();
+                $link->setSku($product->getSku())
+                ->setLinkedProductSku($linkProduct->getSku())
+                ->setLinkType($linkType)
+                ->setPosition(isset($linkData['position']) ? (int)$linkData['position'] : 0);
+                $productLinks[] = $link;
+            }
+        }
+        return $productLinks;
+    }
 }

app/code/Magento/Catalog/Test/Unit/Controller/Adminhtml/Product/Initialization/HelperTest.php

@@ -161,9 +161,7 @@ protected function setUp(): void
             ->getMock();
         $this->productLinksMock = $this->createMock(ProductLinks::class);
         $this->linkTypeProviderMock = $this->createMock(LinkTypeProvider::class);
-        $this->productLinksMock->expects($this->any())
-            ->method('initializeLinks')
-            ->willReturn($this->productMock);
+
         $this->attributeFilterMock = $this->createMock(AttributeFilter::class);
         $this->localeFormatMock = $this->createMock(Format::class);
 
@@ -221,6 +219,7 @@ protected function setUp(): void
      * @param array|null $tierPrice
      * @dataProvider initializeDataProvider
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+     * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function testInitialize(
         $isSingleStore,
@@ -229,8 +228,17 @@ public function testInitialize(
         $links,
         $linkTypes,
         $expectedLinks,
-        $tierPrice = null
+        $tierPrice = null,
+        $isReadOnlyRelatedItems = null,
+        $isReadOnlyUpSellItems = null,
+        $ignoreLinksFlag = false
     ) {
+        $this->productMock->setData('related_readonly', $isReadOnlyRelatedItems);
+        $this->productMock->setData('upsell_readonly', $isReadOnlyUpSellItems);
+        $this->productLinksMock->expects($this->any())
+            ->method('initializeLinks')
+            ->willReturn($this->productMock);
+
         $this->linkTypeProviderMock->expects($this->once())
             ->method('getItems')
             ->willReturn($this->assembleLinkTypes($linkTypes));
@@ -346,6 +354,11 @@ function () {
 
         $productLinks = $this->productMock->getProductLinks();
         $this->assertCount(count($expectedLinks), $productLinks);
+        if ($ignoreLinksFlag) {
+            $this->assertTrue($this->productMock->getDataByKey('ignore_links_flag'));
+        } else {
+            $this->assertFalse($this->productMock->getDataByKey('ignore_links_flag'));
+        }
         $resultLinks = [];
 
         $this->assertEquals($tierPrice ?: [], $this->productMock->getData('tier_price'));
@@ -559,6 +572,34 @@ public static function initializeDataProvider()
                     ['type' => 'related', 'linked_product_sku' => 'Test'],
                 ],
             ],
+
+            // readonly links
+            [
+                'single_store' => false,
+                'website_ids' => ['1' => 1, '2' => 2],
+                'expected_website_ids' => ['1' => 1, '2' => 2],
+                'links' => [
+                    'related' => [
+                        0 => [
+                            'id' => 1,
+                            'thumbnail' => 'http://magento.dev/media/no-image.jpg',
+                            'name' => 'Test',
+                            'status' => 'Enabled',
+                            'attribute_set' => 'Default',
+                            'sku' => 'Test',
+                            'price' => 1.00,
+                            'position' => 1,
+                            'record_id' => 1,
+                        ],
+                    ],
+                ],
+                'linkTypes' => ['related', 'upsell', 'crosssell'],
+                'expected_links' => [],
+                'tierPrice' => [],
+                true,
+                true,
+                true
+            ],
         ];
     }