Merge remote-tracking branch '29147/remove-redundant-methods-1' into julprs

Author: engcom-Charlie

app/code/Magento/AsynchronousOperations/Controller/Adminhtml/Index/Index.php

@@ -6,17 +6,23 @@
 
 namespace Magento\AsynchronousOperations\Controller\Adminhtml\Index;
 
-class Index extends \Magento\Backend\App\Action
+use Magento\Backend\App\Action;
+use Magento\Backend\App\Action\Context;
+use Magento\Framework\App\Action\HttpGetActionInterface;
+use Magento\Framework\View\Result\Page;
+use Magento\Framework\View\Result\PageFactory;
+
+class Index extends Action implements HttpGetActionInterface
 {
     /**
      * Authorization level of a basic admin session
      *
      * @see _isAllowed()
      */
-    const ADMIN_RESOURCE = 'Magento_Logging::system_magento_logging_bulk_operations';
+    public const ADMIN_RESOURCE = 'Magento_Logging::system_magento_logging_bulk_operations';
 
     /**
-     * @var \Magento\Framework\View\Result\PageFactory
+     * @var PageFactory
      */
     private $resultPageFactory;
 
@@ -26,33 +32,24 @@ class Index extends \Magento\Backend\App\Action
     private $menuId;
 
     /**
-     * Details constructor.
-     * @param \Magento\Backend\App\Action\Context $context
-     * @param \Magento\Framework\View\Result\PageFactory $resultPageFactory
+     * @param Context $context
+     * @param PageFactory $resultPageFactory
      * @param string $menuId
      */
     public function __construct(
-        \Magento\Backend\App\Action\Context $context,
-        \Magento\Framework\View\Result\PageFactory $resultPageFactory,
+        Context $context,
+        PageFactory $resultPageFactory,
         $menuId = 'Magento_AsynchronousOperations::system_magento_logging_bulk_operations'
     ) {
         $this->resultPageFactory = $resultPageFactory;
         $this->menuId = $menuId;
         parent::__construct($context);
     }
 
-    /**
-     * @inheritDoc
-     */
-    protected function _isAllowed()
-    {
-        return parent::_isAllowed();
-    }
-
     /**
      * Bulk list action
      *
-     * @return \Magento\Framework\View\Result\Page
+     * @return Page
      */
     public function execute()
     {

app/code/Magento/Sales/Block/Adminhtml/Order/Create/Newsletter.php

@@ -11,12 +11,10 @@
  * @api
  * @since 100.0.2
  */
-class Newsletter extends \Magento\Sales\Block\Adminhtml\Order\Create\AbstractCreate
+class Newsletter extends AbstractCreate
 {
     /**
-     * Constructor
-     *
-     * @return void
+     * @inheritdoc
      */
     protected function _construct()
     {
@@ -43,13 +41,4 @@ public function getHeaderCssClass()
     {
         return 'head-newsletter-list';
     }
-
-    /**
-     * @inheritdoc
-     * phpcs:disable
-     */
-    protected function _toHtml()
-    {
-        return parent::_toHtml();
-    }
 }